ci: derive the build number from the release version - #118
Merged
Merged
Conversation
agvtool next-version bumped the committed build number on every run without committing it back, so every release shipped as build 3. The App Store needs build numbers that increase across uploads, so set CURRENT_PROJECT_VERSION to major*1000000 + minor*1000 + patch (2.26.0 -> 2026000), which always grows with the version and maps back to its tag.
|
🎉 This PR is included in version 2.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CURRENT_PROJECT_VERSIONtomajor*1000000 + minor*1000 + patch(for example 2.26.0 →2026000), replacingagvtool next-version -all.agvtoolbumped the committed build number but never committed it back, so every release shipped as build 3. The App Store requires build numbers that increase across uploads.As a
ci:commit, this won't trigger a release.