fix(memos-local-plugin): detect Hermes chat with global flags#1951
Open
dashitongzhi wants to merge 1 commit into
Open
fix(memos-local-plugin): detect Hermes chat with global flags#1951dashitongzhi wants to merge 1 commit into
dashitongzhi wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the memos-local-plugin bridge’s daemon-mode “Hermes chat running” detection to handle Hermes global CLI flags appearing before the chat subcommand, and adds a unit test to cover the expected matching cases.
Changes:
- Replaced the
pgrep -f "hermes chat"fixed-string match with a configurable pattern constant used byisHermesChatRunning(). - Added a unit test covering: standard
hermes chat, global flags beforechat, and non-chat Hermes commands.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/memos-local-plugin/bridge.cts | Introduces a reusable process-match pattern and uses it for pgrep-based Hermes chat detection. |
| apps/memos-local-plugin/tests/unit/bridge-status.test.ts | Adds a focused unit test validating Hermes chat process detection behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }; | ||
| } | ||
|
|
||
| const HERMES_CHAT_PROCESS_PATTERN = "hermes(?:\\s+\\S+)*\\s+chat\\b"; |
Comment on lines
+12
to
+14
| const escapedPattern = match!.groups!.pattern; | ||
| const pattern = escapedPattern.replaceAll("\\\\", "\\"); | ||
| return new RegExp(pattern).test(command); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1915.
Verification