get_default_cube_config: clear ValueError instead of UnboundLocalError for invalid text_mem_type - #2442
Open
simpleqt wants to merge 1 commit into
Open
get_default_cube_config: clear ValueError instead of UnboundLocalError for invalid text_mem_type#2442simpleqt wants to merge 1 commit into
simpleqt wants to merge 1 commit into
Conversation
get_default_cube_config only assigned text_mem_config inside the tree_text/general_text branches, so any other value crashed with a bare UnboundLocalError. Fixes MemTensor#2441
Memtensor-AI
added
area:core
Collaborator
🤖 Open Code ReviewTarget: PR #2442 ✅ OpenCodeReview: Review complete: 0 finding(s) across 2 selected item(s). Generated by cloud-assistant via Open Code Review. |
Collaborator
✅ Automated Test Results: PASSEDAll tests passed (5/5 executed). memos_python_core/changed-repo-python: 5/5. Duration: 8s [advisory, non-gating] AI-generated tests on branch test/auto-gen-a63e2db40c11703c-20260930220428: 44/44 passed — these do NOT affect the PR verdict; review the branch manually. Branch: |
Memtensor-AI
added
status:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2441
Summary
get_default_cube_configinsrc/memos/mem_os/utils/default_config.pyonly assignstext_mem_configinside thetree_textandgeneral_textbranches, with noelse. Any other value — e.g. a typo like"tree-text"reaching the config plumbing — crashes with a bareUnboundLocalError:Fix
Add the missing
elsebranch raising a clear error that names the accepted values:Regression test
Added
tests/mem_os/test_default_config_text_mem_type.py:UnboundLocalError) and pass with the fixruff check(repo-pinned 0.11.8) passes on both touched files.AI Disclosure