Skip to content

Add negation search support in AE listing detail table - #134

Closed
yihui wants to merge 2 commits into
Merck:mainfrom
yihui:feature/search-negation
Closed

Add negation search support in AE listing detail table#134
yihui wants to merge 2 commits into
Merck:mainfrom
yihui:feature/search-negation

Conversation

@yihui

@yihui yihui commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a custom searchMethod to the nested AE listing reactable so users can prefix a search term with ! to exclude matching rows (e.g., typing !group A hides all rows containing "group A" and shows only groups B, C, D, etc.)
  • Normal (non-negated) search behavior is unchanged

Test plan

  • Run devtools::check() — no new warnings/errors
  • Open an interactive forest plot, expand a row, and verify:
    • Searching "group A" still shows only matching rows
    • Searching "!group A" excludes rows containing "group A"
    • Searching "!" alone (no term) returns all rows

🤖 Generated with Claude Code

yihui and others added 2 commits June 10, 2026 10:28
Users can now prefix search terms with "!" to exclude matching rows
(e.g., "!group A" filters out rows containing "group A").

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Users can now type arbitrary JS expressions in the search bar using `x`
as the cell value, e.g. `x != 'Placebo'`, `x > 80`, `x.includes('foo')`.
Negation expressions filter with every() (exclude matching), positive
expressions filter with some() (include matching). Plain text still works
as substring search.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@yihui

yihui commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #146, which uses the same branch now hosted on Merck/forestly (rather than the yihui/forestly fork) and includes the negation-search fix.

@yihui yihui closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant