style: use compact Unicode symbols instead of emoji in CLI output#1114
Conversation
|
This pull request is part of a stack: |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull request overview
Updates CLI output styling to use compact Unicode symbols instead of emoji for more consistent terminal rendering across environments.
Changes:
- Adds
AGENTS.mddocumenting CLI output guidelines (prefer compact Unicode symbols over emoji). - Replaces emoji status markers in
mergify_cli/stack/setup.pywith✓(and removes the 🤖 header marker). - Removes the warning emoji from the stack
pre-pushhook message.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
mergify_cli/stack/setup.py |
Replaces emoji in setup/status messages with compact Unicode equivalents. |
mergify_cli/stack/hooks/scripts/pre-push.sh |
Removes warning emoji from the pre-push guidance message. |
AGENTS.md |
Adds repository guidance for terminal output symbols vs emoji. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@jd this pull request is now in conflict 😩 |
e7028dc to
5f86e50
Compare
Merge Queue Status
This pull request spent 28 seconds in the queue, with no time running CI. ReasonThe pull request conflicts with the base branch HintYou should update or rebase your pull request. If you want to requeue this pull request, you can post a |
|
@jd this pull request is now in conflict 😩 |
Adds AGENTS.md with CLI output style guideline: prefer compact Unicode symbols (✓ ✗ ● ○ —) over emoji for consistent terminal rendering. Replaces all emoji in the stack module (setup.py, pre-push.sh) with the compact symbols to match the queue module's existing style. Change-Id: Ie9a1cbe04ce1abdd5866e9f7de6d7000e95b9675 Claude-Session-Id: 2d9f4a52-4a1d-4a50-a459-3b57847dec9f
5f86e50 to
e878e0a
Compare
Pull request has been modified.
Merge Queue Status
This pull request spent 59 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
Adds smart_rebase() that detects merged PRs via the GitHub API and handles them during rebase. If merged commits are found, it does a single `git rebase -i` that both drops them and rebases onto trunk, avoiding conflicts from PRs modified on GitHub before merge. If no commits are merged, falls back to simple `git pull --rebase`. Integrated into `mergify stack push` during its rebase step. Claude-Session-Id: 2d9f4a52-4a1d-4a50-a459-3b57847dec9f Depends-On: #1114
Adds AGENTS.md with CLI output style guideline: prefer compact Unicode
symbols (✓ ✗ ● ○ —) over emoji for consistent terminal rendering.
Replaces all emoji in the stack module (setup.py, pre-push.sh) with
the compact symbols to match the queue module's existing style.
Claude-Session-Id: 2d9f4a52-4a1d-4a50-a459-3b57847dec9f