Updating plugin keys for vertical transformation#4425
Open
gabriel-bolbotina wants to merge 1 commit intomasterfrom
Open
Updating plugin keys for vertical transformation#4425gabriel-bolbotina wants to merge 1 commit intomasterfrom
gabriel-bolbotina wants to merge 1 commit intomasterfrom
Conversation
gabriel-bolbotina
changed the title
Pull Request Test Coverage Report for Build 23607057818Details
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
reviewed
Mar 26, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Just a question, why do we want to support both keys? Plugin never got released with the support for this functionality and we just enabled it in few project for very early adopters.
Besides that it looks alright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skipElevationTransformation key is now deprecated in plugin, so the code was modified to support elevationTransformationEnabled.
If skipElevationTransformation was set to false, it means there was vertical transformation enabled, thus elevationTransformationEnabled will then be true and vice versa.
To ensure backwards compatibility, when setting the variable in main, if the reading of the elevationTransformationEnabled key fails, we read the deprecated key.