Skip to content

Adding filter banner component and filtering activated message #4426

Open
gabriel-bolbotina wants to merge 2 commits intodev/filteringfrom
filter-hidden-feature-banner
Open

Adding filter banner component and filtering activated message #4426
gabriel-bolbotina wants to merge 2 commits intodev/filteringfrom
filter-hidden-feature-banner

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

In this PR:

  • created MMFilterBanner component that has a rectangle with customisable message and an action button that can be active or not
  • added a new size for MMButton, ExtraSmall that is used inside the MMFilterBanner and took care of the logic for padding and text
  • added an info message in linked features and gallery editor drawers if the filtering is active
  • added function to check if the referencing layer has an active layer ( could be modified to be in sync with the latest filtering logic)

Below some visuals:

filter-banner-info.MP4

Added extra small MMButton size
Added function to check if the referencing layer is filtered
Added info message in gallery and relation editor pages
Simplified Filter banner component
Added banner in the linked features
corrected position according to figma design
@github-actions
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23648308057

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 57.846%

Files with Coverage Reduction New Missed Lines %
mm/app/filtercontroller.cpp 5 0.0%
mm/app/filtercontroller.h 5 0.0%
Totals Coverage Status
Change from base Build 23430504555: -0.01%
Covered Lines: 8781
Relevant Lines: 15180

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 65801 dmg Expires: 25/06/2026 #6580
linux Build 📬 Mergin Maps 65911 x86_64 Expires: 25/06/2026 #6591
win64 Build 📬 Mergin Maps 57751 win64 Expires: 25/06/2026 #5775
Android Build 📬 Mergin Maps 789251 APK [arm64-v8a] Expires: 25/06/2026 #7892
Android Build 📬 Mergin Maps 789211 APK [armeabi-v7a] Expires: 25/06/2026 #7892
iOS Build Build failed or not found. #8831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant