Skip to content

Filter floating chip#4427

Open
gabriel-bolbotina wants to merge 3 commits intodev/filteringfrom
filter-floating-chip
Open

Filter floating chip#4427
gabriel-bolbotina wants to merge 3 commits intodev/filteringfrom
filter-floating-chip

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

Modified the following:

  • position of the filtering chip
  • icon of the chip, deleting the deprecated filled filter icon
  • formatted the code
  • action of the chip, so if it is tapped then it will go to the filtering section drawer

There are still two main questions to be answered:

  1. In the figma design all map buttons are shown as 32 x 32 icons, whereas on current master they are 24 by 24. Should I update them so that the MMMapButton icon should default to 32 x 32?
  2. Clarify the logic for when showing the chip if the filters are currently disabled or not.

Visual demo:

filter-chip.mov

Deleted filled filter icon
Updated visuals for the chip
Changed the chip position
Formatted code
Updated the chip visuals
Updated the filter svg to be 24 x 24
@github-actions
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23651803605

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 58 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 57.961%

Files with Coverage Reduction New Missed Lines %
mm/app/layerfeaturesmodel.cpp 1 80.47%
mm/core/merginapi.cpp 7 75.3%
mm/app/mmstyle.h 50 1.85%
Totals Coverage Status
Change from base Build 23430504555: 0.1%
Covered Lines: 8795
Relevant Lines: 15174

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 65821 dmg Expires: 25/06/2026 #6582
linux Build 📬 Mergin Maps 65931 x86_64 Expires: 25/06/2026 #6593
win64 Build 📬 Mergin Maps 57771 win64 Expires: 25/06/2026 #5777
Android Build Build failed or not found. #7894
iOS Build Build failed or not found. #8833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant