Fix condition for creating diff checkpoints#607
Merged
Conversation
Enfore rule that checkpoint can not contain basefile in its range. When creating diff chain / history, always lookup with version higher than basefile. This prevents confusion when it is worth creating a diff checkpoint and ensures we only create merged diffs which can actually be applied. As a consequence, gpkg will never have checkpoints starting with version 1.
Coverage Report for CI Build 24184330411Coverage increased (+0.007%) to 93.248%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
MarcelGeo
requested changes
Apr 9, 2026
MarcelGeo
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce rule that checkpoint can not contain basefile in its range.
When creating diff chain / history, always lookup with version higher than basefile. This prevents confusion when it is worth creating a diff checkpoint and ensures we only create merged diffs which can actually be applied.
As a consequence, gpkg will never have checkpoints starting with version 1.