Design doc: how the harness should handle PR review-comment feedback - #26
Open
nishantkluhera wants to merge 1 commit into
Open
Design doc: how the harness should handle PR review-comment feedback#26nishantkluhera wants to merge 1 commit into
nishantkluhera wants to merge 1 commit into
Conversation
Surveyed what exists first: github-pr-workflow is strictly outbound, opensource-contribution ends at PR open, github-code-review and cron are reusable as-is. Key constraint identified: we can never install webhooks on repos we contribute to, so polling GitHub's notifications API via a cronjob is the trigger - zero new infrastructure. Design applies escalate-don't-expand with hard reputation bounds: max 2 automated pushes per review round, max 1 reply per thread, 60min push cool-down, ambiguous always escalates. Classification into mechanical/question/direction-pushback/approval/ambiguous happens in skill prose, not a new core tool. Deliverable shape: one small bundled skill + one stdlib script riding existing rails (cronjob, gh CLI, contrib-screen audit convention). No code, per the issue's scope note. Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-only deliverable for the gap after PR open: review comments, change requests, clarifying questions.
Surveyed what exists first (github-pr-workflow is strictly outbound; opensource-contribution ends at PR open). Key constraint identified: we can never install webhooks on repos we contribute to, so polling GitHub's notifications API via cronjob is the trigger - zero new infrastructure. Escalate-don't-expand with hard reputation bounds: max 2 automated pushes per review round, max 1 reply per thread, 60min cool-down, ambiguous always escalates.
Deliverable shape: one small bundled skill + one stdlib script riding existing rails. Doc in mershlab/design/, fold-in ready for internal-docs.
Addresses #7
Merge order: #25 first, then this.