feat: implement advanced tools framework with thread-safe hooks, caching and external execution#1218
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
feat: implement advanced tools framework with thread-safe hooks, caching and external execution#1218github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
…ing and external execution - Add praisonaiagents/tools/advanced.py with enhanced tool decorators - Support for hooks (before/after with priorities), TTL caching, external execution - Thread-safe implementation using RLock for global state - Async-safe external handler support - Fix decorator bare usage pattern (@advanced_tool vs @advanced_tool()) - Fix parameter naming (Range uses min_val/max_val) - Backward compatible with existing tools system - Comprehensive test suite with 8/8 tests passing - Addresses all critical issues from original PR #980 reviews 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com>
Owner
Contributor
Author
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the advanced tools framework that was originally in PR #980, with all critical issues fixed based on the comprehensive code reviews.
Key Features Implemented:
Critical Issues Fixed:
Test Coverage:
✅ 8/8 comprehensive tests passing:
Architecture:
🤖 Generated with Claude Code