Remove duplicate jules metadata in UM repository - #155
Remove duplicate jules metadata in UM repository#155Maggie (maggiehendry) wants to merge 15 commits into
Conversation
…ecies-specific**
…n be shared and other tidying.
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
Eleanor Burke (eleanorgb)
left a comment
There was a problem hiding this comment.
This looks good to me.
Arthur Argles (mo-arthurargles)
left a comment
There was a problem hiding this comment.
JULES-RED namelist looks good (tick from veg3/Demography), JULES, UM, LFRic tests appear look to have passed.
If I understand correctly this bit of the code does not directly effect the JULES science rose stem tests?
Could you "tick" off the relevant boxes for science review such as standards or AI attribution (if any) in the PR's makes things easier for reviewers.
PR Summary
Sci/Tech Reviewer:
Code Reviewer:
Please see linked Issue #154 and Sharing JULES metadata for a description of the project.
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
rose-meta/jules-sharedthen have you supplied a linked UM and LFRic Apps PR?Testing
trac.log
Test Suite Results - jules - jules-test-154-remove-duplicate-jules-metadata-in-um-repository/run1
Suite Information
Task Information
✅ succeeded tasks - 4
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
Approvals
Please request all relevant approvals. See the CodeOwners.txt file for section owners.
Technical
Scientific
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review