Skip to content

Remove duplicate jules metadata in UM repository - #155

Draft
Maggie (maggiehendry) wants to merge 15 commits into
MetOffice:mainfrom
maggiehendry:154-remove-duplicate-jules-metadata-in-um-repository
Draft

Remove duplicate jules metadata in UM repository#155
Maggie (maggiehendry) wants to merge 15 commits into
MetOffice:mainfrom
maggiehendry:154-remove-duplicate-jules-metadata-in-um-repository

Conversation

@maggiehendry

@maggiehendry Maggie (maggiehendry) commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

Please see linked Issue #154 and Sharing JULES metadata for a description of the project.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • If editing rose-meta/jules-shared then have you supplied a linked UM and LFRic Apps PR?

Testing

  • I have tested this change locally, using the JULES rose-stem suite
  • If shared files have been modified, I have run the UM and LFRic Apps rose stem suites
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system tests, unit tests, etc.)

trac.log

Test Suite Results - jules - jules-test-154-remove-duplicate-jules-metadata-in-um-repository/run1

Suite Information

Item Value
Suite Name jules-test-154-remove-duplicate-jules-metadata-in-um-repository/run1
Suite User margaret.hendry
Workflow Start 2026-09-01T16:32:03
Groups Run scripts
Dependency Reference Main Like
jules maggiehendry/jules@test-154-remove-duplicate-jules-metadata-in-um-repository False
SimSys_Scripts MetOffice/SimSys_Scripts@2026.07.1 True

Task Information

✅ succeeded tasks - 4

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Approvals

Please request all relevant approvals. See the CodeOwners.txt file for section owners.

Technical

  • JULES Code Owner
  • OpenMP
  • River Routing
  • Rose Stem
  • Rose Metadata
  • Upgrade Macros

Scientific

  • Surface
  • Hydrology
  • Vegetation
  • Veg3 RED Demography
  • Biogeochemistry
  • Biogenic fluxes
  • Fire
  • Lakes
  • Evaluation
  • Imogen

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@maggiehendry Maggie (maggiehendry) self-assigned this Aug 31, 2026
@github-actions github-actions Bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Aug 31, 2026
@maggiehendry Maggie (maggiehendry) linked an issue Aug 31, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ Hello Maggie (@maggiehendry)!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

@eleanorgb Eleanor Burke (eleanorgb) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@nicgedney Nic Gedney (nicgedney) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JULES-RED namelist looks good (tick from veg3/Demography), JULES, UM, LFRic tests appear look to have passed.

If I understand correctly this bit of the code does not directly effect the JULES science rose stem tests?

Could you "tick" off the relevant boxes for science review such as standards or AI attribution (if any) in the PR's makes things easier for reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-modified The CLA has been modified as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove duplicate JULES metadata in UM repository

5 participants