Manage iodef core no_del tweak_iodef - #447
Open
mo-marqh wants to merge 18 commits into
Open
Conversation
mo-marqh
requested review from
a team,
James Bruten (james-bruten-mo),
Mike Hobson (mike-hobson) and
Ricky Wong (mo-rickywong)
as code owners
August 13, 2026 13:26
| import pytest | ||
|
|
||
|
|
||
| # security pattern to check whether `src` links are local and link to known |
Contributor
There was a problem hiding this comment.
Could you double check this regex and it's comment please?
I don't think it matches strings starting with ../metadata.
I also think it will match some non-alphabetic following characters, for example I think:
$SOURCE_ROOT/bob/bruce matches
etc/bob33 matches
etc/33bob doesn't match
…on, to avoid need for rose env-cat
mo-marqh
force-pushed
the
manage_iodef_core_nodel_tweak
branch
from
August 19, 2026 15:49
09acf87 to
eef6855
Compare
Member
Author
|
tests rerun and updated trac.log output placed in PR description |
Member
Author
|
hopefully ready for re-review Harry Shepherd (@harry-shepherd) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Harry Shepherd (@harry-shepherd) - -->
Code Reviewer: Benjamin Went (@MetBenjaminWent)
This PR removes the
lfric_coredependency ontweak_iodefThe script is left in the source until a following PR can remove
lfric_appsdependency on this, at which point it can be deleted.Instead, XML component fragments are addressed directly, through source symlinks, and through rose / cylc configurations
This then enables static analysis of XML files that are used as
iodef.xmlfiles by XIOS, introducing testing of XML in the source tree and the opportunity for XML rules encoded in the depths of the lfric xios interface to be tested directly, improving management of XML configurationsCode Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - manage_iodef_core/run4
Suite Information
Task Information
✅ succeeded tasks - 434
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review