Enable variable precision checkpoint-restart files - #456
Open
iboutle wants to merge 2 commits into
Open
Conversation
28 tasks
iboutle
marked this pull request as ready for review
August 28, 2026 08:10
iboutle
requested review from
Ricky Wong (mo-rickywong)
and removed request for
a team
August 28, 2026 08:10
Harry Shepherd (harry-shepherd)
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Harry Shepherd (@harry-shepherd)
Code Reviewer: Ricky Wong (@mo-rickywong)
Currently, checkpoint-restart files are forced to be double-precision, by the setting of
prec="8"in various xml files. Typically, we run the model at single-precision, and therefore are writing checkpoint-restart files which are double the size they need to be.These PRs fix this, by removing the precision from the xml file specification, and setting it instead via the model-xios interface depending on the precision of the model.
They also provide some preparatory work required for packing of diagnostics, namely removing the precision specification from diagnostic files, instead specifying the precision in the diagnostics definition. In future this will allow packed
prec="2"diagnostics to be added, without their precision being over-ridden by theprecspecification of the diagnostic files.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - spdump_core/run1
Suite Information
Task Information
✅ succeeded tasks - 433
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review