Skip to content

CONF-1943: Persist chain-agnostic Solana Pay intents - #10272

Draft
pedronfigueiredo wants to merge 2 commits into
mainfrom
pnf/conf-1943-persist-solana-pay-intent-model
Draft

pedronfigueiredo wants to merge 2 commits into
mainfrom
pnf/conf-1943-persist-solana-pay-intent-model

Conversation

@pedronfigueiredo

@pedronfigueiredo pedronfigueiredo commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • store validated CAIP-10 source account and CAIP-19 source asset metadata on the already-persisted target TransactionMeta.metamaskPay record
  • derive the source chain from both identifiers and reject mismatches without projecting Solana identifiers into legacy EVM Hex fields
  • keep quote, instruction, and ordinary Pay selection state transient while preserving existing EVM Pay behavior
  • expose the focused setPaySource controller action and preserve source metadata when compatibility metrics are refreshed

Design scope

The original dual-store, versioned intent model was broader than CONF-1943 requires. Solana Pay needs CAIP-compatible source metadata because its source submission is not represented by a local EVM transaction, but that metadata now has one durable owner: the target transaction's existing metamaskPay record.

At-most-once source execution, request correlation, and recovery checkpoints will be introduced only in stacked #10273, where they have their first safety consumer. This PR contains no retry or resubmission behavior.

Validation

  • yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/TransactionPayController.test.ts
  • yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/utils/quotes.test.ts
  • yarn workspace @metamask/transaction-pay-controller run test
  • yarn workspace @metamask/transaction-controller run test --runInBand
  • yarn workspace @metamask/transaction-controller run build
  • yarn workspace @metamask/transaction-pay-controller run build
  • changed-file ESLint for both affected packages
  • yarn workspace @metamask/transaction-pay-controller run messenger-action-types:check
  • yarn changelog:validate

Solana Pay ticket and PR index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant