Skip to content

feat(kyc-controller): throw on all errors rather than silently log - #10292

Open
jiexi wants to merge 1 commit into
mainfrom
jl/kyc-controller-remove-more-silent-fails
Open

jiexi wants to merge 1 commit into
mainfrom
jl/kyc-controller-remove-more-silent-fails

Conversation

@jiexi

@jiexi jiexi commented Sep 17, 2026

Copy link
Copy Markdown
Member

Explanation

Previously we had only switched some methods from silent throwing to explicit throws. This PR switches the remaining silent throws. This is being done because the silent throwing pattern causes significant grief and results in awful error handling on the caller side

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@jiexi
jiexi requested review from a team as code owners September 17, 2026 22:20
@jiexi
jiexi deployed to default-branch September 17, 2026 22:20 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant