feat(money-account-controller): multi-keyring accounts and default (POC) - #10299
Draft
matthiasgeihs wants to merge 1 commit into
Draft
matthiasgeihs wants to merge 1 commit into
matthiasgeihs wants to merge 1 commit into
Conversation
…lt account Allow Money and MPC keyring accounts in the same controller, with create/add APIs and getMoneyAccount() resolving to a configurable default. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MoneyAccountControllercan hold multipleKeyringAccounts from Money and MPC keyrings at once.createMoneyAccount({ keyringType, ... })(Money: create-if-missing; MPC: existing keyring only +addAccounts(1)),addMoneyAccount,setDefaultMoneyAccount, and persisteddefaultMoneyAccountId.MoneyAccountis nowKeyringAccount;getMoneyAccount()with no args returns the default account, not the primary HD entropy source.Test plan
yarn workspace @metamask/money-account-controller run testkeyringIdwhen more than one existssetDefaultMoneyAccountswitchesaddMoneyAccountregisters an already-built account without KeyringController callsclearStateclears accounts and defaultMPCKeyring.addAccountsin the accounts repo; do not treat this as client-ready until that landsMade with Cursor