Skip to content

fix(ramps-controller): omit crypto from payment methods requests - #10307

Open
amitabh94 wants to merge 2 commits into
mainfrom
fix/ramps-payments-omit-crypto
Open

amitabh94 wants to merge 2 commits into
mainfrom
fix/ramps-payments-omit-crypto

Conversation

@amitabh94

Copy link
Copy Markdown
Contributor

Explanation

GET /v2/regions/:region/payments is scoped to provider and region. The API already ignores crypto, but RampsService.getPaymentMethods still put the token on the query string.

That made Cloudflare treat each token as a distinct cache object for the same payment list, so token changes on the input screen missed CDN and hit origin.

This stops sending crypto on that request. assetId stays on the method for caller cache keys and staleness checks. Quotes still send crypto and still use Cache-Control: no-store.

References

Related to on-ramp-api quote RegionCache work (explicit-provider fast path). Client-side companion to reducing /payments CDN fragmentation.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Made with Cursor

Payment methods depend on provider and region. Sending crypto on the URL was ignored by the API and split the CDN cache per token.

Co-authored-by: Cursor <cursoragent@cursor.com>
@amitabh94
amitabh94 requested review from a team as code owners September 21, 2026 04:01
@amitabh94
amitabh94 deployed to default-branch September 21, 2026 04:01 — with GitHub Actions Active
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant