Conversation
Payment methods depend on provider and region. Sending crypto on the URL was ignored by the API and split the CDN cache per token. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
GET /v2/regions/:region/paymentsis scoped to provider and region. The API already ignorescrypto, butRampsService.getPaymentMethodsstill put the token on the query string.That made Cloudflare treat each token as a distinct cache object for the same payment list, so token changes on the input screen missed CDN and hit origin.
This stops sending
cryptoon that request.assetIdstays on the method for caller cache keys and staleness checks. Quotes still sendcryptoand still useCache-Control: no-store.References
Related to on-ramp-api quote RegionCache work (explicit-provider fast path). Client-side companion to reducing
/paymentsCDN fragmentation.Checklist
Made with Cursor