fix: pin the Renovate version - #10371
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Renovate pull requests opened today carry an artifact failure, #10369 for example:
Renovate fell back to the Yarn 1 in its own image instead of resolving Yarn from
packageManager, so the lockfile is not updated properly.This is a known upstream bug, not our config.
generateLockFilefor Yarn chooses between Corepack and the Yarn 1 fallback usingmanagerData.hasPackageManager, and that flag gets lost on some update shapes. Open since November 2023 as renovate#25853, with an unmerged fix in renovate#45153. One of our five failures,fast-xml-parser, is in the rootresolutionsblock, which is exactly the case that PR describes.What changed today is how often we hit it.
renovatebot/github-actiondefaultsrenovate-versionto the floating44tag, so pinning the action by SHA does nothing for the Renovate version inside it. From our own run logs:renovate/execa-10.xis the controlled case: it produced a correct lockfile on 44.106.0 and failed on 44.107.0.So this pins
renovate-versionto 44.106.0. Treat it as a stopgap rather than a root cause fix. Nothing in the 44.107.0 changelog touches Yarn or Corepack, its six commits are all Helm, mise, docs and CI, so the trigger is more likely the rebuilt base image or cache state than Renovate source. If the failures come back on 44.106.0 we will know the pin was the wrong lever and the real answer is waiting on renovate#45153.Deliberately no
# renovate:annotation on the pin: nothing in CI exercises a Renovate run, so an automatic bump would put us back here without warning.The already open pull requests need their rebase checkbox ticked afterwards to pick up a good lockfile.
References
Follows #10334. Part of WPC-1161.
Checklist