Skip to content

chore(deps): update dependency node-fetch to v3 #10378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metamask-ci wants to merge 1 commit into
base: main
Choose a base branch
from
+53 −2
Open

chore(deps): update dependency node-fetch to v3 #10378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/network-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"jest-when": "^4.0.3",
"lodash-es": "^4.17.21",
"nock": "^13.5.6",
"node-fetch": "^2.7.0",
"node-fetch": "^3.3.2",

@cursor cursor Bot Sep 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESM upgrade breaks Jest test imports

High Severity

Bumping node-fetch to v3 makes the package ESM-only, but Jest still compiles these tests to CommonJS. Existing FetchError imports will throw ERR_REQUIRE_ESM on Node 22, which CI still runs.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e259150. Configure here.

"rimraf": "^6.1.3",
"ts-jest": "^29.4.12",
"tsx": "^4.23.15",
Expand Down
53 changes: 52 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8126,7 +8126,7 @@ __metadata:
lodash-es: "npm:^4.17.21"
loglevel: "npm:^1.8.1"
nock: "npm:^13.5.6"
node-fetch: "npm:^2.7.0"
node-fetch: "npm:^3.3.2"
reselect: "npm:^5.1.1"
rimraf: "npm:^6.1.3"
ts-jest: "npm:^29.4.12"
Expand Down Expand Up @@ -16150,6 +16150,13 @@ __metadata:
languageName: node
linkType: hard

"data-uri-to-buffer@npm:^4.0.0":
version: 4.0.1
resolution: "data-uri-to-buffer@npm:4.0.1"
checksum: 10/0d0790b67ffec5302f204c2ccca4494f70b4e2d940fea3d36b09f0bb2b8539c2e86690429eb1f1dc4bcc9e4df0644193073e63d9ee48ac9fce79ec1506e4aa4c
languageName: node
linkType: hard

"data-urls@npm:^5.0.0":
version: 5.0.0
resolution: "data-urls@npm:5.0.0"
Expand Down Expand Up @@ -17953,6 +17960,16 @@ __metadata:
languageName: node
linkType: hard

"fetch-blob@npm:^3.1.2, fetch-blob@npm:^3.1.4":
version: 3.2.0
resolution: "fetch-blob@npm:3.2.0"
dependencies:
node-domexception: "npm:^1.0.0"
web-streams-polyfill: "npm:^3.0.3"
checksum: 10/5264ecceb5fdc19eb51d1d0359921f12730941e333019e673e71eb73921146dceabcb0b8f534582be4497312d656508a439ad0f5edeec2b29ab2e10c72a1f86b
languageName: node
linkType: hard

"figures@npm:^6.1.0":
version: 6.1.0
resolution: "figures@npm:6.1.0"
Expand Down Expand Up @@ -18207,6 +18224,15 @@ __metadata:
languageName: node
linkType: hard

"formdata-polyfill@npm:^4.0.10":
version: 4.0.10
resolution: "formdata-polyfill@npm:4.0.10"
dependencies:
fetch-blob: "npm:^3.1.2"
checksum: 10/9b5001d2edef3c9449ac3f48bd4f8cc92e7d0f2e7c1a5c8ba555ad4e77535cc5cf621fabe49e97f304067037282dd9093b9160a3cb533e46420b446c4e6bc06f
languageName: node
linkType: hard

"forwarded@npm:0.2.0":
version: 0.2.0
resolution: "forwarded@npm:0.2.0"
Expand Down Expand Up @@ -22588,6 +22614,13 @@ __metadata:
languageName: node
linkType: hard

"node-domexception@npm:^1.0.0":
version: 1.0.0
resolution: "node-domexception@npm:1.0.0"
checksum: 10/e332522f242348c511640c25a6fc7da4f30e09e580c70c6b13cb0be83c78c3e71c8d4665af2527e869fc96848924a4316ae7ec9014c091e2156f41739d4fa233
languageName: node
linkType: hard

"node-emoji@npm:^2.1.0":
version: 2.2.0
resolution: "node-emoji@npm:2.2.0"
Expand All @@ -22614,6 +22647,17 @@ __metadata:
languageName: node
linkType: hard

"node-fetch@npm:^3.3.2":
version: 3.3.2
resolution: "node-fetch@npm:3.3.2"
dependencies:
data-uri-to-buffer: "npm:^4.0.0"
fetch-blob: "npm:^3.1.4"
formdata-polyfill: "npm:^4.0.10"
checksum: 10/24207ca8c81231c7c59151840e3fded461d67a31cf3e3b3968e12201a42f89ce4a0b5fb7079b1fa0a4655957b1ca9257553200f03a9f668b45ebad265ca5593d
languageName: node
linkType: hard

"node-gyp-build@npm:^4.2.0":
version: 4.8.1
resolution: "node-gyp-build@npm:4.8.1"
Expand Down Expand Up @@ -28137,6 +28181,13 @@ __metadata:
languageName: node
linkType: hard

"web-streams-polyfill@npm:^3.0.3":
version: 3.3.3
resolution: "web-streams-polyfill@npm:3.3.3"
checksum: 10/8e7e13501b3834094a50abe7c0b6456155a55d7571312b89570012ef47ec2a46d766934768c50aabad10a9c30dd764a407623e8bfcc74fcb58495c29130edea9
languageName: node
linkType: hard

"web3-core@npm:^4.4.0, web3-core@npm:^4.5.0, web3-core@npm:^4.6.0, web3-core@npm:^4.7.1":
version: 4.7.1
resolution: "web3-core@npm:4.7.1"
Expand Down
Loading