Merged
Conversation
shane-t
reviewed
Apr 10, 2026
Jwhiles
force-pushed
the
add-chomp-api
branch
4 times, most recently
from
d8926ef to
010ce60
Compare
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
5 times, most recently
from
8b2387c to
2e23109
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
shane-t
reviewed
Apr 15, 2026
shane-t
reviewed
Apr 15, 2026
shane-t
reviewed
Apr 15, 2026
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
7bb3882 to
debd7eb
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
debd7eb to
e31c503
Compare
Contributor
Author
|
@metamaskbot publish-preview |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Jwhiles
force-pushed
the
add-chomp-api
branch
2 times, most recently
from
178d32d to
a820fad
Compare
MoMannn
previously approved these changes
Apr 20, 2026
MoMannn
previously approved these changes
Apr 20, 2026
mcmire
reviewed
Apr 20, 2026
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
47347bf to
fc0757b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
fc0757b to
d644130
Compare
1. use correct version 2. remove unused state 3. remove unused imports in tsconfig
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
49c0a6b to
89c36c5
Compare
mcmire
requested changes
Apr 20, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 00781c8. Configure here.
mcmire
reviewed
Apr 20, 2026
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
00781c8 to
c4311aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a scaffold for the money account upgrade controller, as well the first step in the upgrade process.
I'll make follow up PRs adding the further steps so they can be reviewed more easily.
Addresses
MUSD-447 and MUSD-449
References
Checklist
Note
Medium Risk
Adds a new controller that signs messages via
KeyringControllerand calls the CHOMP API, so mistakes could impact authentication/association flows despite limited initial scope.Overview
Introduces a new package,
@metamask/money-account-upgrade-controller, providing a scaffoldedMoneyAccountUpgradeControllerwithinit(validates chain support viaChompApiService:getServiceDetails) and a messenger-exposedupgradeAccountmethod that runs an ordered upgrade step sequence.Adds the first upgrade step,
associateAddressStep, which EIP-191 signs aCHOMP Authentication {timestamp}message and submits it toChompApiService:associateAddress, treatingalready_associatedas a no-op; includes unit tests and wires the package into repo build/TS references, README package list, CODEOWNERS/teams.json, andyarn.lock.Reviewed by Cursor Bugbot for commit c4311aa. Bugbot is set up for automated code reviews on this repo. Configure here.