Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
bergarces
force-pushed
the
native-asset-detection
branch
from
a7ae91d to
f57ddeb
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 994d5ea. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The code for the new controller currently considers that only assets in the slip44 namespace are native. This limits support for prices on many chains supported by price-api. With this changes, we create a centralised way of determining if an asset is native, as well as support chains for which price-api does not yet support the slip44 entry or for which there is none.
Not doing this would cause a regression when the new controller is updated.
With AssetsController enabled without this changes, we are missing support for chains that already had support before. Mostly due to using a wrong default instead of a specific assetId.
References
Checklist
Note
Medium Risk
Changes how assets are classified as native across multiple data sources and legacy formatting paths, which can affect balances/prices and downstream consumers if misidentified. Logic is straightforward but touches core asset pipelines for EVM chains with non-standard native representations.
Overview
Introduces a shared
isNativeAssethelper and replaces scatteredslip44/string checks acrossAssetsController,RpcDataSource,BackendWebsocketDataSource,TokenDataSource, andBalanceFetcher, so native assets are recognized even when represented aserc20:(including known IDs fromSPOT_PRICES_SUPPORT_INFOand zero-address ERC-20).Updates bridge and transaction-pay legacy format conversions to use
getNativeTokenAddress(chainId)(instead of always the zero address) when emitting native token entries, and adjusts RPC native asset ID fallback to${chainId}/erc20:${ZERO_ADDRESS}. Also exportsSPOT_PRICES_SUPPORT_INFOfrom@metamask/assets-controllersand updates tests to expect chain-specific native addresses (e.g., Polygon0x…1010).Reviewed by Cursor Bugbot for commit cf3f16d. Bugbot is set up for automated code reviews on this repo. Configure here.