fix(transaction-pay-controller): poll Across status by deposit txn ref#8489
Open
pedronfigueiredo wants to merge 1 commit intomainfrom
Open
fix(transaction-pay-controller): poll Across status by deposit txn ref#8489pedronfigueiredo wants to merge 1 commit intomainfrom
pedronfigueiredo wants to merge 1 commit intomainfrom
Conversation
136908d to
eda47ab
Compare
Fix Across deposit status polling to query /deposit/status with depositTxnRef=<source tx hash> instead of misusing the quote id as depositId. Also handle fillTxnRef in the response so the status poller can return the fill transaction reference when Across provides it. This resolves the repeated 400s seen after the source-chain tx finalized by aligning the request and response handling with Across' current status API shape.
eda47ab to
fe98acc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fix Across deposit status polling to query /deposit/status with depositTxnRef= instead of misusing the quote id as depositId.
Also handle fillTxnRef in the response so the status poller can return the fill transaction reference when Across provides it.
This resolves the repeated 400s seen after the source-chain tx finalized by aligning the request and response handling with Across' current status API shape.
References
Checklist
Note
Medium Risk
Changes the bridge completion polling request/response logic, which can affect whether intents resolve to the correct destination transaction hash; scope is small and covered by updated unit tests.
Overview
Fixes Across completion polling by querying
/deposit/statuswithdepositTxnRef=<source tx hash>(instead of passing quote/deposit id params), aligning with Across’ current status API.Updates the status response handling to prefer
fillTxnRefwhen returning the destination/fill transaction reference (falling back todestinationTxHash,fillTxHash,txHash, then the source hash), with tests and changelog updated accordingly.Reviewed by Cursor Bugbot for commit fe98acc. Bugbot is set up for automated code reviews on this repo. Configure here.