Skip to content

fix: replace computed Network enum initialisers with string literals #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmalik88 merged 4 commits into from
Aug 4, 2026
+8 −5
Merged

fix: replace computed Network enum initialisers with string literals #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fc9479
fix: replace computed Network enum initialisers with string literals …
hmalik88 Aug 4, 2026
5d2b17a
chore: update changelog entry
hmalik88 Aug 4, 2026
ef25e6b
fix: changelog
hmalik88 Aug 4, 2026
f24e2ee
fix: tron shasum
hmalik88 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/tron-wallet-snap/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add `bip44:discover` support to `createAccounts`: checks on-chain activity across all Tron networks before persisting; returns `[]` if no activity to signal end-of-discovery to the client. ([#56](https://github.com/MetaMask/internal-snaps/pull/56))
- Add `endowment:keyring` capabilities to manifest declaring the `tron:728126428` scope, hexadecimal private key export, and BIP-44 derivation strategies. ([#56](https://github.com/MetaMask/internal-snaps/pull/56))

### Fixed

- Fix `bip44:discover` always failing due to `Network` enum being compiled bidirectionally by TypeScript when initialised from another enum's members, causing `Object.values(Network)` to include human-readable names (`"Mainnet"` etc.) alongside scope IDs; replaced enum initialisers with string literals so TypeScript emits a one-way mapping. ([#101](https://github.com/MetaMask/internal-snaps/pull/101))

## [2.0.0]

### Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/tron-wallet-snap/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/internal-snaps.git"
},
"source": {
"shasum": "AzSGXXOl7hLkleKs2n45byefpbqom1y+l1ik4ucTd4Y=",
"shasum": "kpXPl/gHuE6MQIAy2ZxMvI3XByIC/Gj7xss6WPFWCe4=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
7 changes: 3 additions & 4 deletions packages/tron-wallet-snap/src/constants/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { TrxScope } from '@metamask/keyring-api';
import { BigNumber } from 'bignumber.js';

export const ZERO = BigNumber(0);
Expand Down Expand Up @@ -33,9 +32,9 @@ export const TRACK_TX_INTERVAL = 'PT3S';
export const TRACK_TX_MAX_ATTEMPTS = 5;

export enum Network {
Mainnet = TrxScope.Mainnet,
Nile = TrxScope.Nile,
Shasta = TrxScope.Shasta,
Mainnet = 'tron:728126428',
Nile = 'tron:3448148188',
Shasta = 'tron:2494104990',
}

export enum KnownCaip19Id {
Expand Down
Loading