feat(tron-wallet-snap): route fungible reads through Core AssetsController - #96
Draft
ulissesferreira wants to merge 4 commits into
Draft
feat(tron-wallet-snap): route fungible reads through Core AssetsController#96ulissesferreira wants to merge 4 commits into
ulissesferreira wants to merge 4 commits into
Conversation
2 tasks
ulissesferreira
force-pushed
the
WPN-1497-messenger-plumbing
branch
from
July 31, 2026 22:32
2339dbc to
1413a43
Compare
ulissesferreira
force-pushed
the
WPN-1497-core-adapter-routing
branch
from
July 31, 2026 22:36
3e08eaa to
c278782
Compare
ulissesferreira
force-pushed
the
WPN-1497-core-adapter-routing
branch
from
July 31, 2026 22:45
e6ff082 to
7e28dbf
Compare
ulissesferreira
marked this pull request as draft
August 2, 2026 17:39
ulissesferreira
force-pushed
the
WPN-1497-messenger-plumbing
branch
from
August 2, 2026 20:48
e2a7495 to
64e6d11
Compare
ulissesferreira
force-pushed
the
WPN-1497-core-adapter-routing
branch
2 times, most recently
from
August 2, 2026 20:59
01f94f8 to
aec97ce
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ulissesferreira
force-pushed
the
WPN-1497-messenger-plumbing
branch
from
August 2, 2026 23:20
b73d987 to
7302e9d
Compare
ulissesferreira
force-pushed
the
WPN-1497-core-adapter-routing
branch
from
August 2, 2026 23:20
6f74385 to
1ad0e7a
Compare
2 tasks
ulissesferreira
commented
Aug 3, 2026
| ): Promise<AssetEntity | null> { | ||
| if (isSnapOwnedAsset(assetId)) { | ||
| return this.#snapAdapter.getAccountAssetByID(accountId, assetId); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This shouldn't exist
ulissesferreira
commented
Aug 3, 2026
| return ASSETS_MIGRATION_STAGE; | ||
| } | ||
|
|
||
| async #getProviderAccountAssetByID( |
Contributor
Author
There was a problem hiding this comment.
Unnecessary indirection
ulissesferreira
commented
Aug 3, 2026
| return mapControllerAsset(accountId, asset); | ||
| } | ||
|
|
||
| async #getProviderAccountAssetsByIDs( |
Contributor
Author
There was a problem hiding this comment.
Unnecessary indirection
ulissesferreira
commented
Aug 3, 2026
| ); | ||
| } | ||
|
|
||
| async #getProviderAccountAssetsByScope( |
Contributor
Author
There was a problem hiding this comment.
Unnecessary indirection
ulissesferreira
commented
Aug 3, 2026
| } | ||
|
|
||
| return this.#getProviderAccountAssetByID(accountId, assetId); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We don't need the fallback thing. Just an if with an early return and everything else
cursor
Bot
force-pushed
the
WPN-1497-messenger-plumbing
branch
from
August 4, 2026 11:09
f5bde1f to
f53d7bf
Compare
Bump devDependency to match snap-networks-utils baseline. Update AssetsService test mocks for v13 SnapsAssetsMigrationStage enum names and RemoteFeatureFlagController:getState return shape. Co-authored-by: Cursor <cursoragent@cursor.com>
…vider Adopt @metamask/snap-networks-utils AssetsProvider from day one for account-scoped AssetsController reads (getAccountAssetByID, getAccountAssetsByIDs, getAccountAssetsByScope) behind migration-stage routing in AssetsService. Map controller Asset shapes to private AssetEntity via mapControllerAsset; protocol assets remain Snap-owned through SnapAssetsAdapter. CoreAssetsAdapter is not used. Co-authored-by: Cursor <cursoragent@cursor.com>
…red AssetsProvider Wire @metamask/tron-wallet-snap to @metamask-previews/snap-networks-utils@0.0.0-preview-8589132 (published from PR #82) via npm alias, replacing workspace:^ to satisfy yarn constraints. Allow the preview dependency range in yarn.config.cjs until PR #82 merges. Co-authored-by: Cursor <cursoragent@cursor.com>
ulissesferreira
force-pushed
the
WPN-1497-messenger-plumbing
branch
from
August 4, 2026 13:45
f53d7bf to
c9d4f0c
Compare
ulissesferreira
force-pushed
the
WPN-1497-core-adapter-routing
branch
from
August 4, 2026 13:45
1a63feb to
3dc547d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CoreAssetsAdapterandmapControllerAssetfor CoreAssetsControllerreadsSnapAssetsAdapter; narrow sync/saveManyto snap-owned when Core stage is activeAssetsController:getAssetandAssetsController:getAssetsPart 2 of 2 split from #94. Part 1:
WPN-1497-messenger-plumbing.Jira
Test plan
yarn workspace @metamask/tron-wallet-snap buildyarn workspace @metamask/tron-wallet-snap run jest --no-coverage(898 tests)Stacks on PR 1 (
WPN-1497-messenger-plumbing), which stacks on #92.Supersedes #94.