fix(useAsyncCallback): update component mount state handling to prevent ref issues in StrictMode

[Prithpal-Sooriya]

Description

This useAsyncCallback in dev StrictMode loses its data on refire (via unmount/remount). Caused issues with token details page opening

Changelog

CHANGELOG entry: fix(useAsyncCallback): update component mount state handling to prevent ref issues in StrictMode

Related issues

Fixes: N/A

Manual testing steps

1. Go to search
2. Select Token you don't own
3. Expected Token Details Page Opens

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Two-line hook lifecycle change; fixes dev StrictMode behavior without altering production mount/unmount semantics.

Overview
useAsyncCallback now sets isMounted.current = true when its mount effect runs, not only on cleanup to false. In React StrictMode (dev), the simulated unmount left the ref false after remount, so execute could bail out immediately and async results never updated—e.g. token details after search.

useAsyncResult inherits the fix because it builds on useAsyncCallback.

^{Reviewed by Cursor Bugbot for commit 7b70295. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[dan437]

I also ran into this issue, Network fee was not loading in the Send flow.

[MajorLift]

Good call. Also documented this in this ticket for defining a useIsMounted hook: https://github.com/MetaMask/MetaMask-planning/issues/6544

[DDDDDanica]

Thanks so much for the quick fix 🙏🏻

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[metamask-ci]

Builds ready [7b70295]

• ⚠️ Make sure the build is safe before downloading and running this build.
  • Please do not use these builds with accounts that contain significant real money.
  • Beware the security risks of cache poisoning.
• Webpack builds: chrome, firefox
• Webpack builds (beta): chrome, firefox
• Webpack builds (flask): chrome, firefox
• Webpack builds (test): chrome, firefox
• Webpack builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• bundle analyzer: Bundle Analyzer
• interaction-benchmark: Interaction Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 16 warn · 🔴 1 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31103431545 | Baseline logs

Metrics	chrome-webpack	firefox-webpack
onboardingNewWallet [Sentry log · main/release]	🟢 [CI log]	🔴 [CI log]

Regressions (🔴 1 failure)

• onboardingNewWallet [Sentry log · main/release] · firefox-webpack — total(p75) [CI log]

Interaction Benchmarks · Samples: 5

Benchmark	chrome-webpack	firefox-webpack
loadNewAccount [Sentry log · main/release]	🟡 [CI log] 🟡 load_new_account	🟡 [CI log] 🟡 load_new_account
confirmTx [Sentry log · main/release]	🟡 [CI log]	🟡 [CI log]
bridgeUserActions [Sentry log · main/release]	🟢 [CI log]	🟢 [CI log]

📈 Results compared to the previous 5 runs on main

• ↑ loadNewAccount/load_new_account: +18%
• ↑ loadNewAccount/total: +18%
• ↓ confirmTx/longTaskTotalDuration: -16%
• ↑ confirmTx/longTaskMaxDuration: +36%
• ↓ confirmTx/tbt: -28%
• ↑ bridgeUserActions/bridge_load_asset_picker: +53%
• ↓ bridgeUserActions/longTaskCount: -44%
• ↓ bridgeUserActions/longTaskTotalDuration: -56%
• ↓ bridgeUserActions/longTaskMaxDuration: -35%
• ↓ bridgeUserActions/tbt: -80%
• ↑ loadNewAccount/load_new_account: +21%
• ↑ loadNewAccount/total: +21%
• ↓ loadNewAccount/inp: -24%
• ↓ loadNewAccount/fcp: -47%
• ↑ loadNewAccount/lcp: +1194%
• ↓ confirmTx/longTaskCount: -100%
• ↓ confirmTx/longTaskTotalDuration: -100%
• ↓ confirmTx/longTaskMaxDuration: -100%
• ↓ confirmTx/tbt: -100%
• ↓ confirmTx/inp: -32%
• ↑ confirmTx/lcp: +1226%
• ↑ bridgeUserActions/bridge_load_page: +199%
• ↑ bridgeUserActions/bridge_load_asset_picker: +85%
• ↓ bridgeUserActions/longTaskCount: -100%
• ↓ bridgeUserActions/longTaskTotalDuration: -100%
• ↓ bridgeUserActions/longTaskMaxDuration: -100%
• ↓ bridgeUserActions/tbt: -100%
• ↑ bridgeUserActions/total: +205%
• ↓ bridgeUserActions/inp: -23%
• ↓ bridgeUserActions/fcp: -48%
• ↑ bridgeUserActions/lcp: +1114%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

• 🟡 confirmTx/FCP: p75 1.8s
• 🟡 confirmTx/FCP: p75 1.8s

Startup Benchmarks · Samples: 100

Benchmark	chrome-webpack	firefox-webpack
startupStandardHome [Sentry log · main/release]	🟢 [CI log]	🟡 [CI log] 🟡 loadScripts
startupPowerUserHome [Sentry log · main/release]	–	🟡 [CI log]

📈 Results compared to the previous 5 runs on main

• ↓ startupStandardHome/firstReactRender: -99%
• ↓ startupStandardHome/numNetworkReqs: -14%
• ↓ startupStandardHome/domInteractive: -17%
• ↓ startupStandardHome/firstReactRender: -98%
• ↓ startupStandardHome/initialActions: -50%
• ↓ startupStandardHome/numNetworkReqs: -13%
• ↓ startupPowerUserHome/uiStartup: -19%
• ↓ startupPowerUserHome/firstReactRender: -99%
• ↑ startupPowerUserHome/initialActions: +11%
• ↓ startupPowerUserHome/setupStore: -70%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

• 🟡 startupPowerUserHome/LCP: p75 2.6s

User Journey Benchmarks · Samples: 5 · mock API 🔴 1

Benchmark	chrome-webpack	firefox-webpack
onboardingImportWallet [Sentry log · main/release]	🟡 [CI log] 🟡 total	🟢 [CI log]
onboardingNewWallet [Sentry log · main/release]	🟢 [CI log] 🔴 total	🔴 [CI log] 🔴 total
assetDetails [Sentry log · main/release]	🟡 [CI log]	🟡 [CI log]
solanaAssetDetails [Sentry log · main/release]	🟡 [CI log]	🟡 [CI log]
importSrpHome [Sentry log · main/release]	🟡 [CI log]	🟡 [CI log]
sendTransactions [Sentry log · main/release]	🟡 [CI log]	🟡 [CI log]
swap [Sentry log · main/release]	🟡 [CI log] 🟡 total	🟢 [CI log]

📈 Results compared to the previous 5 runs on main

• ↑ onboardingImportWallet/srpButtonToSrpForm: +12%
• ↓ onboardingImportWallet/metricsToWalletReadyScreen: -10%
• ↓ onboardingImportWallet/doneButtonToHomeScreen: -78%
• ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -52%
• ↓ onboardingImportWallet/longTaskCount: -86%
• ↓ onboardingImportWallet/longTaskTotalDuration: -95%
• ↓ onboardingImportWallet/longTaskMaxDuration: -92%
• ↓ onboardingImportWallet/tbt: -99%
• ↓ onboardingImportWallet/total: -81%
• ↓ onboardingNewWallet/longTaskCount: -38%
• ↓ onboardingNewWallet/longTaskTotalDuration: -46%
• ↓ onboardingNewWallet/longTaskMaxDuration: -23%
• ↓ onboardingNewWallet/tbt: -62%
• ↑ solanaAssetDetails/assetClickToPriceChart: +318%
• ↓ solanaAssetDetails/longTaskCount: -100%
• ↓ solanaAssetDetails/longTaskTotalDuration: -100%
• ↓ solanaAssetDetails/longTaskMaxDuration: -100%
• ↓ solanaAssetDetails/tbt: -100%
• ↑ solanaAssetDetails/total: +318%
• ↑ solanaAssetDetails/inp: +11%
• ↑ solanaAssetDetails/fcp: +21%
• ↓ importSrpHome/loginToHomeScreen: -14%
• ↓ importSrpHome/homeAfterImportWithNewWallet: -12%
• ↓ importSrpHome/longTaskCount: -44%
• ↓ importSrpHome/longTaskTotalDuration: -46%
• ↓ importSrpHome/longTaskMaxDuration: -17%
• ↓ importSrpHome/tbt: -44%
• ↓ importSrpHome/total: -12%
• ↓ importSrpHome/inp: -38%
• ↑ importSrpHome/fcp: +12%
• ↑ importSrpHome/cls: +519%
• ↑ sendTransactions/selectTokenToSendFormLoaded: +57%
• ↓ sendTransactions/reviewTransactionToConfirmationPage: -97%
• ↓ sendTransactions/longTaskCount: -100%
• ↓ sendTransactions/longTaskTotalDuration: -100%
• ↓ sendTransactions/longTaskMaxDuration: -100%
• ↓ sendTransactions/tbt: -100%
• ↓ sendTransactions/total: -94%
• ↓ sendTransactions/inp: -19%
• ↑ sendTransactions/fcp: +14%
• ↓ sendTransactions/lcp: -60%
• ↑ sendTransactions/cls: +171%
• ↑ swap/openSwapPageFromHome: +883%
• ↑ swap/fetchAndDisplaySwapQuotes: +135%
• ↑ swap/longTaskCount: +33%
• ↓ swap/longTaskTotalDuration: -16%
• ↓ swap/longTaskMaxDuration: -12%
• ↓ swap/tbt: -100%
• ↑ swap/total: +149%
• ↓ swap/lcp: -71%
• ↓ swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

• 🟡 assetDetails/FCP: p75 1.9s
• 🟡 solanaAssetDetails/FCP: p75 1.9s
• 🟡 importSrpHome/FCP: p75 1.9s
• 🟡 sendTransactions/FCP: p75 1.9s
• 🟡 swap/FCP: p75 1.9s
• 🟡 assetDetails/FCP: p75 1.9s
• 🟡 solanaAssetDetails/FCP: p75 1.9s
• 🟡 importSrpHome/FCP: p75 1.9s
• 🔴 sendTransactions/INP: p75 560ms

Dapp Page Load Benchmarks · Samples: 100

Benchmark	chrome-webpack
dappPageLoad [Sentry log · main/release]	🟢 [CI log]

📈 Results compared to the previous 5 runs on main

• ↓ dappPageLoad/pageLoadTime: -58%
• ↓ dappPageLoad/firstPaint: -46%
• ↓ dappPageLoad/firstContentfulPaint: -46%

Bundle size diffs

• background: 105 Bytes (0%)
• ui: 64 Bytes (0%)
• common: 0 Bytes (0%)
• other: 0 Bytes (0%)
• contentScripts: 0 Bytes (0%)
• zip: 52 Bytes (0%)