fix: align account selector transitions with main stack#29606
fix: align account selector transitions with main stack#29606DostoevskysPiano wants to merge 3 commits intomainfrom
Conversation
Match Reanimated enter/exit to @react-navigation/stack horizontal presets (TransitionIOSSpec on iOS, ScaleFromCenterAndroid timing/easing on Android). Made-with: Cursor
|
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 0 out of 1 committers have signed the CLA. |
Made-with: Cursor
|
Validation (local): |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Since the AccountSelector is a core component used in account switching flows, SmokeAccounts is the most relevant tag to verify the animation changes don't break account selection functionality. The functional behavior (account switching, selection, navigation) remains unchanged, so the risk is low. CHANGELOG.md is documentation only and requires no testing. No other tags are needed since:
Performance Test Selection: |
|


Description
The full-page account list (
AccountSelector) animates in Reanimated while the parent stack hasanimationEnabled: false, so its motion was decoupled from other primary flows. Opening used a much lighter spring than iOSUINavigationController, and closing used a fixed150mstiming that did not match stack-driven screens (e.g. Settings, token details).This change applies the same transition spec as
@react-navigation/stackhorizontal presets: on iOS,withSpringusing the library’sTransitionIOSSpecparameters; on Android,withTimingwith400msand theScaleFromCenterAndroidbezier easing. Enter and exit both use the same family of motion per platform so the account list should feel consistent with other slide-from-right stack screens.Validation: ESLint reports no issues on
AccountSelector.tsx. Runyarn jest --runTestsByPath app/components/Views/AccountSelector/AccountSelector.test.tsx --watchman=falselocally if duplicate.claude/worktrees/paths affect Jest discovery.Changelog
CHANGELOG entry: Aligned full-page account list open and close animations with main stack horizontal transition timing
Related issues
No issue: polish / consistency with existing navigation transition presets.
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
AccountSelectorunit tests; no new cases required for timing constants)Performance checks (if applicable)
trace()for usage andaddTokenfor an examplePre-merge reviewer checklist