feat(predict): clob v2 cleanup core (testing E2E fixes)

[MarioAslau]

Description

This PR removes legacy Predict Polymarket CLOB v1 support and completes the pUSD migration in Predict-owned code.

It includes:

• CLOB v2 as the unconditional Polymarket protocol path.
• Removal of CLOB v1 protocol selection, order codec branches, and v1 Safe helper wrappers.
• pUSD as the canonical Predict trading, fee, deposit, withdraw, reward-fee, and claim gas top-up token.
• Legacy Safe USDC.e retained only as temporary hidden sweep state.
• Legacy USDC.e → pUSD sweep preflight for deposit, withdraw, trade, and claim operations.
• Displayed Predict balance as total recoverable Predict funds (pUSD + legacy USDC.e).
• In-memory cache to stop refetching legacy USDC.e balance for a Safe after a zero balance is observed.

Stack note: this PR is stacked on the confirmations-only pUSD PR so the diff stays limited to Predict-owned files.

Changelog

CHANGELOG entry: Updated Predict to use pUSD and the Polymarket CLOB v2 protocol.

Related issues

Fixes: PRED-851 , PRED-852

Manual testing steps

Feature: Predict pUSD migration

  Scenario: user with pUSD places a Predict trade
    Given the user has a funded Predict Safe with pUSD
    When the user places a Predict trade
    Then the order is submitted through the CLOB v2 path
    And pUSD is used for trading and fee authorization

  Scenario: legacy user performs their first Predict operation
    Given the user has legacy USDC.e in their Predict Safe
    When the user deposits, withdraws, trades, or claims
    Then the Safe preflight wraps legacy USDC.e into pUSD before the main operation

Screenshots/Recordings

Before

N/A — code-only protocol migration PR; no screenshots captured.

After

N/A — code-only protocol migration PR; no screenshots captured.

Testing

• yarn lint:tsc
• yarn jest app/components/UI/Predict/providers/polymarket/protocol/definitions.test.ts app/components/UI/Predict/providers/polymarket/protocol/orderCodec.test.ts app/components/UI/Predict/providers/polymarket/protocol/transport.test.ts app/components/UI/Predict/providers/polymarket/preflight/v2AllowanceRequirements.test.ts app/components/UI/Predict/providers/polymarket/preflight/withdraw.test.ts app/components/UI/Predict/providers/polymarket/preflight/workflows.test.ts app/components/UI/Predict/providers/polymarket/PolymarketProvider.test.ts app/components/UI/Predict/controllers/PredictController.test.ts app/components/UI/Predict/hooks/usePredictBalanceTokenFilter.test.ts app/components/UI/Predict/hooks/usePredictRewards.test.ts app/components/UI/Predict/views/PredictBuyWithAnyToken/components/PredictPayWithRow/PredictPayWithRow.test.tsx --runInBand --forceExit

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Updates Predict transaction batching to use the v2 collateral (pUSD) as the gasFeeToken and switches rewards fee-asset IDs to pUSD, which can impact on-chain transaction submission and points estimation. Also changes balance-row display metadata and removes hasAllowances from account-state expectations, so regressions would mainly show up in Predict payment UI/state handling.

Overview
Predict now uses the CLOB v2 collateral (MATIC_CONTRACTS_V2.collateral, i.e. pUSD) when submitting claim/withdraw transaction batches by setting it as the gasFeeToken.

The Predict payment token list row is updated to be pUSD-centric: it pulls the pUSD token image, shows the formatted balance as the row description, and labels the fiat description as pUSD.

Rewards estimation requests now report the fee asset as POLYGON_PUSD_CAIP_ASSET_ID (and corresponding comment/test updates), and usePredictAccountState tests/docs are aligned to no longer expect hasAllowances in returned AccountState.

^{Reviewed by Cursor Bugbot for commit f259c47. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePredictions, SmokeConfirmations, SmokeWalletPlatform
• Selected Performance tags: None (no tests recommended)
• Risk Level: high
• AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR makes a significant protocol migration in the Polymarket/Predict feature: switching from USDC.e (legacy v1 protocol) to pUSD (Polymarket USD, v2 protocol) as the collateral token. Key changes:

1. SmokePredictions (primary): All 4 predict smoke tests were directly modified (predict-open-position, predict-cash-out, predict-claim-positions, predict-withdraw). The core PredictController.ts now uses MATIC_CONTRACTS_V2 for gasFeeToken. PolymarketProvider.ts had major refactoring - v1 protocol removed entirely, v2 is now the only protocol. All polymarket mock infrastructure updated (polymarket-constants.ts, polymarket-mocks.ts, polymarket-rpc-response.ts). These tests must run to validate the pUSD migration works end-to-end.

2. SmokeConfirmations (required per tag description + direct change): transaction-pay.spec.ts is a SmokeConfirmations test that was directly modified to use pUSD instead of USDC.e as the output token. The relay quote mock (transaction-pay.ts) was updated to reference pUSD. Per SmokePredictions tag description: 'When selecting SmokePredictions, also select SmokeConfirmations (opening/closing positions are on-chain transactions).'

3. SmokeWalletPlatform (required per tag description): Per SmokePredictions tag description: 'Predictions is also a section inside the Trending tab (SmokeWalletPlatform); changes to Predictions views affect Trending. When selecting SmokePredictions, also select SmokeWalletPlatform (Trending section).' The PredictPayWithRow.tsx UI component was also updated.

The risk is high because this is a fundamental protocol change affecting the collateral token address used across all Predict flows (deposit, withdraw, claim, trade). The feature flag predictClobV2Enabled was removed entirely, making v2 the permanent protocol - any regression would break all Predict functionality.

Performance Test Selection:
The changes are focused on the Polymarket/Predict protocol migration (USDC.e to pUSD) and do not affect core performance-sensitive areas like app startup, account list rendering, login flows, or asset loading. The changes are primarily business logic (contract addresses, protocol definitions) and E2E test infrastructure updates. No performance-critical rendering paths, Redux state management, or initialization code was modified.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud