test: align polymarket utils tests with clob cleanup

[ghgoodreau]

Description

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Updates token addresses/metadata used for Predict gas fee payments and rewards estimation, so an incorrect constant could affect on-chain transactions or points calculations. Changes are localized but touch transaction submission parameters and token display.

Overview
Predict now uses the new Polygon collateral contract (MATIC_CONTRACTS_V2.collateral / POLYGON_PUSD) when setting gasFeeToken for claim/withdraw transaction batches and when estimating Rewards points (switches fee asset from USDC to pUSD).

The Predict balance token list row is updated to use the pUSD token image, show the formatted balance as the description, and add fiat_description: 'pUSD'; tests are adjusted accordingly. Account state hook/tests are also aligned to no longer expect/cover hasAllowances.

^{Reviewed by Cursor Bugbot for commit a30e7c7. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 88.37209% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.52%. Comparing base (51b6bbd) to head (a30e7c7).
⚠️ Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
...Predict/providers/polymarket/PolymarketProvider.ts	85.71%	3 Missing and 1 partial ⚠️
...redict/providers/polymarket/protocol/orderCodec.ts	50.00%	1 Missing and 1 partial ⚠️
.../UI/Predict/providers/polymarket/preflight/core.ts	83.33%	0 Missing and 1 partial ⚠️
.../Predict/providers/polymarket/preflight/deposit.ts	75.00%	1 Missing ⚠️
...UI/Predict/providers/polymarket/preflight/trade.ts	66.66%	0 Missing and 1 partial ⚠️
...ents/UI/Predict/providers/polymarket/safe/utils.ts	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #29617      +/-   ##
==========================================
- Coverage   82.15%   81.52%   -0.64%     
==========================================
  Files        5178     5226      +48     
  Lines      137450   138358     +908     
  Branches    31079    31395     +316     
==========================================
- Hits       112924   112790     -134     
- Misses      16875    17826     +951     
- Partials     7651     7742      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePredictions, SmokeConfirmations, SmokeWalletPlatform
• Selected Performance tags: @PerformancePredict
• Risk Level: high
• AI Confidence: 92%

click to see 🤖 AI reasoning details

E2E Test Selection:
This PR migrates the Polymarket/Predict integration from USDC.e (legacy V1 collateral) to pUSD (Polymarket USD, V2 collateral). This is a significant protocol-level change affecting:

1. SmokePredictions (primary): All four predict smoke tests are directly modified (predict-open-position, predict-cash-out, predict-claim-positions, predict-withdraw). The core PredictController and PolymarketProvider are updated to use pUSD as the collateral token. The V1 protocol is removed entirely, leaving only V2. Mock infrastructure (polymarket-constants, polymarket-mocks) is updated to reflect pUSD contract addresses and balance tracking. These tests must run to verify the pUSD migration works end-to-end.

2. SmokeConfirmations: The transaction-pay.spec.ts file is directly modified - it's tagged under SmokeConfirmations and tests the deposit confirmation flow. The token address changed from USDC.e (0x2791...) to pUSD (0xC011...), and expected fee amounts were updated. This test must run to verify the confirmation UI correctly displays pUSD deposit transactions.

3. SmokeWalletPlatform: Per the tag description, Predictions is a section inside the Trending tab. Changes to Predictions views (including PredictPayWithRow which now uses POLYGON_PUSD instead of POLYGON_USDCE) affect the Trending integration. The tag description explicitly states 'changes to Perps, Predictions, or Tokens views... that are embedded in Trending affect this tag.'

The risk is high because:

• Core protocol logic changed (V1 removed, V2 only)
• Contract addresses changed (different token contract)
• Balance calculation logic changed (pUSD + legacy USDC.e sweep)
• Multiple transaction flows affected (deposit, withdraw, claim, cash-out, open position)
• The backward-compat aliases (POLYMARKET_USDC_BALANCE_MOCKS, POST_CLAIM_USDC_BALANCE_WEI etc.) ensure existing callers still work but the underlying behavior changed

Performance Test Selection:
The PredictController and PolymarketProvider have significant changes to balance fetching logic - now fetching both pUSD and legacy USDC.e balances in parallel (Promise.all), adding a new cache (#safeAddressesWithZeroLegacyUsdceBalance) for legacy balance optimization. The balance calculation path changed from summing multiple tokens to a combined pUSD + legacy sweep approach. These changes could affect the performance of the Predict balance loading and display flows, warranting a @PerformancePredict test run.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud