[ON HOLD] feat: remove globally mounted useEnsureMusdTokenRegistered in favour of @metamask/assets-controllers automatic mUSD tracking by Matt561 · Pull Request #29622 · MetaMask/metamask-mobile

Matt561 · 2026-05-01T17:48:42Z

DO NOT MERGE - These changes lead to missing mUSD asset icons.

Description

This PR removes the globally mounted useEnsureMusdTokenRegistered() since the @metamask/assets-controllers now auto-track mUSD.

Changes:

bumped @metamask/assets-controller to ^6.3.0
bumped @metamask/assets-controllers to ^105.1.0
Removed globally mounted useEnsureMusdTokenRegistered
Removed ensureMusdTokenRegistered

Changelog

CHANGELOG entry: removed globally mounted useEnsureMusdTokenRegistered; bumped @metamask/assets-controller to ^6.3.0; bumped @metamask/assets-controllers to ^105.1.0.

Related issues

Fixes:

Manual testing steps

Feature: Automatic mUSD tracking on mainnet, Linea, and Monad

  Scenario: mUSD automatically tracked
    Given user onboards a new wallet that doesn't have mUSD

    When user opens app
    Then mUSD is tracked by default

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
I've tested with a power user scenario
- Use these power-user SRPs to import wallets with many accounts and tokens
I've instrumented key operations with Sentry traces for production performance metrics
- See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

^{Cursor Bugbot is generating a summary for commit 400616a. Configure here.}

…rs now automatically tracks mUSD

github-actions · 2026-05-01T17:48:56Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2026-05-01T17:51:50Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
npm/@metamask/assets-controller@6.2.1 ⏵ 6.3.0		⁺¹	⁺¹
npm/@metamask/assets-controllers@105.0.0 ⏵ 105.1.0	⁺¹	⁺¹	⁺¹
npm/@metamask/keyring-controller@25.2.0 ⏵ 25.4.0		⁺¹	⁺²
npm/@metamask/network-controller@30.0.1 ⏵ 30.1.0		⁺¹	⁺²
npm/@metamask/eth-json-rpc-middleware@23.1.2 ⏵ 23.1.3	⁺¹	⁺¹	⁺¹
npm/@metamask/json-rpc-engine@10.2.4 ⏵ 10.3.0			⁺⁴

View full report

codecov-commenter · 2026-05-01T18:05:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.79%. Comparing base (51b6bbd) to head (d755890).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #29622       +/-   ##
===========================================
- Coverage   82.15%   61.79%   -20.37%     
===========================================
  Files        5178     5225       +47     
  Lines      137450   138558     +1108     
  Branches    31079    31452      +373     
===========================================
- Hits       112924    85616    -27308     
- Misses      16875    46232    +29357     
+ Partials     7651     6710      -941

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…rollers-packages

github-actions · 2026-05-01T19:11:58Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
Risk Level: high
AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/assets-controller, @metamask/assets-controllers. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/assets-controller, @metamask/assets-controllers. Running all tests.

View GitHub Actions results

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 400616a. Configure here.}

cursor · 2026-05-01T19:13:59Z

  CHAIN_IDS.LINEA_MAINNET, // Linea mainnet
 ];

-/**


Unused constant and import left behind after removal

Low Severity

MUSD_TOKEN_REGISTRATION_CHAIN_IDS_FALLBACK is now dead code. Its only consumer, selectMusdTokenRegistrationChainIds, was removed in this PR, but the constant itself (along with its JSDoc) remains exported from index.ts, and the test file still imports it at line 17 without using it anywhere. Both the export and the import are unused and can be removed.

Additional Locations (1)

app/components/UI/Earn/selectors/featureFlags/index.test.ts#L16-L17

^{Reviewed by Cursor Bugbot for commit 400616a. Configure here.}

sonarqubecloud · 2026-05-01T19:28:19Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-05-01T19:33:58Z

⚠️ E2E Fixture Validation — Structural changes detected

Category	Count
New keys	24
Missing keys	24
Type mismatches	0
Value mismatches	12 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

Matt561 added 4 commits May 1, 2026 13:00

chore: bump @metamask/assets-controller to ^6.3.0

026641c

chore: bump @metamask/assets-controllers to ^105.1.0

86553be

chore: ran yarn dedupe

ba4cc51

feat: revert changes introduced in #28130. @metamask/assets-controlle…

d755890

…rs now automatically tracks mUSD

Matt561 added the team-earn label May 1, 2026

github-actions Bot added the size-L label May 1, 2026

Matt561 changed the title ~~chore/bump assets controller and assets controllers packages~~ feat: remove globally mounted useEnsureMusdTokenRegistered in favour of @metamask/assets-controllers automatic mUSD tracking May 1, 2026

Matt561 and others added 2 commits May 1, 2026 14:13

feat: add mUSD to assetsInfo in initial-background-state.json

d65914e

Merge branch 'main' into chore/bump-assets-controller-and-assets-cont…

400616a

…rollers-packages

Matt561 marked this pull request as ready for review May 1, 2026 19:10

Matt561 requested review from a team as code owners May 1, 2026 19:10

cursor Bot reviewed May 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ON HOLD] feat: remove globally mounted useEnsureMusdTokenRegistered in favour of @metamask/assets-controllers automatic mUSD tracking#29622

[ON HOLD] feat: remove globally mounted useEnsureMusdTokenRegistered in favour of @metamask/assets-controllers automatic mUSD tracking#29622
Matt561 wants to merge 6 commits intomainfrom
chore/bump-assets-controller-and-assets-controllers-packages

Matt561 commented May 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

socket-security Bot commented May 1, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented May 1, 2026

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot May 1, 2026

Uh oh!

sonarqubecloud Bot commented May 1, 2026

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Matt561 commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DO NOT MERGE - These changes lead to missing mUSD asset icons.

Description

Changes:

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

socket-security Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented May 1, 2026

Codecov Report

Uh oh!

github-actions Bot commented May 1, 2026

🔍 Smart E2E Test Selection

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 1, 2026

Choose a reason for hiding this comment

Unused constant and import left behind after removal

Uh oh!

sonarqubecloud Bot commented May 1, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Matt561 commented May 1, 2026 •

edited

Loading

socket-security Bot commented May 1, 2026 •

edited

Loading