chore: migrate direct TextField usages for design system 0.22#29624
chore: migrate direct TextField usages for design system 0.22#29624georgewrmarshall wants to merge 1 commit intomainfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: The PR bumps @metamask/design-system-react-native from 0.21.0 to 0.22.0 and migrates TextField component usage across multiple critical views to use the new Affected flows and corresponding tags:
The Login view change is particularly critical as it's used in almost every E2E test flow. However, since the change is a refactor (same props, different nesting), and the design system version bump likely introduced this new API, the risk is primarily that the TextField component correctly forwards these props. The testID/accessibilityLabel being inside inputProps is the main concern for test selector resolution. Tags NOT selected:
Performance Test Selection: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
|



Description
Upgrades
@metamask/design-system-react-nativeto^0.22.0and updates the app's direct design-systemTextFieldandTextFieldSearchusages to the new API.This migration moves native
TextInputprops underinputProps, switches ref-based call sites toinputRef, and updates test selectors where thetestIDnow belongs on the inner input instead of the outer wrapper. It keeps the scope limited to direct imports from the design-system package rather than touching the local compatibility wrapper.Validated with targeted unit tests covering the migrated login, password, onboarding, card authentication, and search flows.
Changelog
CHANGELOG entry: null
Related issues
Fixes: No issue: maintenance-only design system migration.
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes how critical password/auth inputs wire through
TextField(props/ref/testIDs), which can subtly break focus/submit behavior or automated tests despite being a mostly mechanical migration.Overview
Upgrades
@metamask/design-system-react-nativeto^0.22.0and migrates directTextField/TextFieldSearchusages to the new API by moving nativeTextInputprops underinputPropsand switching refs toinputRef.Updates multiple auth/password entry surfaces (card authentication incl. OTP, login, choose/reset password, manual backup password confirmation, OAuth rehydration, rewards referral input, explore search) and adjusts unit tests/mocks/selectors so
testID/queries target the inner input element under the new contract.Reviewed by Cursor Bugbot for commit 9c84278. Bugbot is set up for automated code reviews on this repo. Configure here.