feat: Support profile based Perps trading fee grants [NEEDS CORE PR MERGED/RELEASED FIRST]

[geositta]

Description

Adds support for profile-based Perps trading fee grants. These grants apply to eligible Profile Sync users independently of Rewards opt-in or VIP membership.

Mobile retrieves grants using the Profile Sync JWT and supplies them to the fee resolver introduced in
MetaMask/core#10664. Core selects the lowest applicable fee and returns its source with the quote, preventing Mobile from applying discounts twice.

The UI now presents the resolved source appropriately:

• VIP rewards retain the VIP badge.
• Profile grants display “Promotional discount.”
• Subscription or mixed/unknown discounts display “Fee discount.”

This also adds accurate original fee totals, mixed-source handling for close all flows, runtime response validation, stale profile protection, and focused test coverage.

Changelog

CHANGELOG entry: Added profile based promotional fee grants for eligible Perps trades.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-4020

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches fee quoting, Rewards API auth, and payment-adjacent display logic across many Perps surfaces; incorrect grant or double-discount handling would misstate costs to users.

Overview
Adds profile-based Perps trading fee grants wired through Rewards (getPerpsTradingFeeGrant, Profile Sync JWT on GET /trading-fee-grants) and mobile infrastructure, without gating VIP discount lookup on the VIP feature flag. Bumps @metamask/perps-controller to a preview build so Core resolves the winning fee and returns feeSource; mobile hooks (usePerpsOrderFees, usePerpsCloseAllCalculations) stop re-applying Rewards discounts and only derive presentation via new feeDiscount helpers.

Fee UI now distinguishes attribution: VIP badge for rewards, “Promotional discount” for grants, generic “Fee discount” otherwise (PerpsFeeDiscountLabel, updated tooltips and trade/close summaries with originalTotalFees / feeDiscountKind). Close-all aggregation weights by notional and uses generic labeling when sources mix.

Separately, transaction history treats missing realized PnL as unknown (blank close amounts, safer fill aggregation) instead of coercing to zero.

^{Reviewed by Cursor Bugbot for commit af50d38. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask-previews/​perps-controller@​19.0.0-preview-0305ce0

View full report

[github-actions]

Smart E2E Test Selection

Selected E2E tags: ALL

Selected Performance tags: @PerformancePreps

AI Confidence: 100

E2E reasoning

Expand to read

This PR introduces significant changes to the Perps fee discount system and RewardsController:

1. Package version update (hard rule seed: ALL): @metamask/perps-controller updated to a preview version 19.0.0-preview-0305ce0. This is a controller package change that could affect perps behavior broadly.

2. SmokePerps (primary): Direct changes to perps fee display (PerpsFeesDisplay, PerpsFeeDiscountLabel replacing RewardsVipBadge), fee discount logic (new feeDiscount.ts utility with vip/promotional/generic kinds), order fees hooks (usePerpsOrderFees, usePerpsRewards, usePerpsCloseAllCalculations), close position flows (PerpsClosePositionBottomSheet, PerpsCloseAllPositionsView), trade screen (PerpsTradeScreen), and mobile infrastructure adapter (getPerpsTradingFeeGrant). These changes directly affect the perps Add Funds flow and position management.

3. SmokeWalletPlatform (required by SmokePerps tag description): Perps is a section inside the Trending tab. Changes to Perps views (PerpsCloseAllPositionsView, PerpsOrderView, PerpsProMarketView) affect Trending.

4. SmokeConfirmations (required by SmokePerps tag description): Perps Add Funds deposits are on-chain transactions that go through the confirmation flow. Fee display changes in the trade screen affect what users see during confirmation.

The hard rule seed selected ALL due to the controller package version update. I'm refining to the most relevant tags since the changes are scoped to Perps/Rewards functionality. The RewardsController changes (new getPerpsTradingFeeGrant method) and the perps-controller preview version are the highest-risk elements, but they primarily affect the perps flow rather than all wallet functionality. The activity adapter fix for perps transactions without PnL is also scoped to perps transaction history display.

Performance reasoning

Expand to read

The perps fee calculation logic has been significantly refactored (usePerpsOrderFees, usePerpsCloseAllCalculations, usePerpsRewards hooks all updated). The mobile infrastructure adapter now calls getPerpsTradingFeeGrant in addition to getPerpsDiscountForAccount, adding a new async call to the fee resolution path. These changes could impact perps market loading, position management, and add funds flow performance. @PerformancePreps covers perps market loading, position management, add funds flow, and order execution - all directly affected by these fee calculation changes.

View run

[metamask-ci]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Manual testing steps still contain template content (the Gherkin example title or a [...] placeholder). Replace with real steps, or write N/A — <reason>.
• Pre-merge author checklist has unchecked items (e.g. "I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ec648e6. Configure here.}

[github-actions]

⚡ Performance Test Results

ℹ️ Performance test results are currently non-blocking and will not block this PR.

⚠️ Results incomplete — No test results found

---

Branch: TAT-4020-rewards-grant · Build: E2E · Commit: 2e39f1e · View full run

[sonarqubecloud]

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud