Skip to content

Fix null reference in IsLocalPlayerDeafened and add error logging #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hypercat101 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

Fix null reference in IsLocalPlayerDeafened and add error logging #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a726e8
Fix IsLocalPlayerDeafened check to prevent null reference exceptions …
hypercat101 Apr 16, 2026
de3d245
Add back the comments - Didnt mean to remove them
hypercat101 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NetProviders/FishNet/FishNetNetProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class FishNetNetProvider : NetworkBehaviour, INetProvider
public static IReadOnlyList<FishNetNetProvider> Instances => instances;
#endregion

bool INetProvider.IsLocalPlayerDeafened => LocalPlayerInstance.MetaVc.isDeafened;
bool INetProvider.IsLocalPlayerDeafened => LocalPlayerInstance != null && LocalPlayerInstance.MetaVc.isDeafened;

public MetaVc MetaVc { get; private set; }

Expand Down
2 changes: 1 addition & 1 deletion NetProviders/Mirror/MirrorNetProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class MirrorNetProvider : NetworkBehaviour, INetProvider
public static IReadOnlyList<MirrorNetProvider> Instances => instances;
#endregion

bool INetProvider.IsLocalPlayerDeafened => LocalPlayerInstance.MetaVc.isDeafened;
bool INetProvider.IsLocalPlayerDeafened => LocalPlayerInstance != null && LocalPlayerInstance.MetaVc.isDeafened;

public MetaVc MetaVc { get; private set; }

Expand Down
8 changes: 7 additions & 1 deletion NetProviders/Netick/NetickNetProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class NetickNetProvider : NetworkBehaviour, INetProvider
public static IReadOnlyList<NetickNetProvider> Instances => instances;
#endregion

bool INetProvider.IsLocalPlayerDeafened => LocalPlayerInstance.MetaVc.isDeafened;
bool INetProvider.IsLocalPlayerDeafened => LocalPlayerInstance != null && LocalPlayerInstance.MetaVc.isDeafened;

public MetaVc MetaVc { get; private set; }

Expand Down Expand Up @@ -78,6 +78,12 @@ public override void NetworkDestroy()

void INetProvider.RelayFrame(int index, double timestamp, ReadOnlySpan<byte> data)
{
if (VoiceDataTransmitter == null)
{
Debug.LogError("[MetaVoiceChat] MetaVoiceChatNetick component is missing from the Sandbox prefab.");
return;
}

float additionalLatency = GetAdditionalLatency();

if (Sandbox.IsServer)
Expand Down