Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the API path configuration to use FastAPI's root_path parameter instead of manually prefixing each router. This change simplifies router definitions by removing the need for the API_PREFIX setting at the router level, replacing it with a ROOT_PATH setting applied once at the FastAPI application initialization.
Key changes:
- Replaced
API_PREFIXwithROOT_PATHin application settings - Applied
root_pathparameter when initializing the FastAPI application - Simplified all router prefix definitions to use relative paths
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| app/config.py | Renamed API_PREFIX setting to ROOT_PATH |
| app/main.py | Added logic to set FastAPI root_path from settings |
| app/health/router.py | Removed settings import and simplified router prefix |
| app/cases/router.py | Removed settings import and simplified router prefix |
| app/applicants/router.py | Simplified router prefix to use relative path |
| app/admin/router.py | Simplified router prefix to use relative path |
| README.md | Updated documentation to reference ROOT_PATH instead of API_PREFIX |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):