Extended build-and-test pipeline for net10 support#175
Conversation
.github/workflows/build-and-test.yml
Outdated
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: 8.0.x | ||
| dotnet-version: ${{ matrix.dotnet-version }} |
There was a problem hiding this comment.
The build step builds both .NET 8, .NET 10, so executing it twice is waste.
There was a problem hiding this comment.
The build was duplicating the work, not tests 😄. It was actually a good thing to run tests on both .NET 8 and .NET 10. I would prefer to have duplicated build with tests running on both .NET 8 & .NET 10. I guess this is still acceptable for FuncSharp.
There was a problem hiding this comment.
Hmm it looks likes it does run for both, but it fails for both 😄
There was a problem hiding this comment.
Nice! Didn't notice this. But it looks like it doesn't execute any test 😄
https://github.com/MewsSystems/FuncSharp/runs/55938503031
But it looks like it was broken even before.
There was a problem hiding this comment.
Yeah, I'm looking into it if I can spot the issue
.github/workflows/build-and-test.yml
Outdated
| - name: Test (.NET 8) | ||
| run: dotnet test --no-restore --no-build --configuration $config --framework net8.0 --logger "trx;LogFileName=test-results-net8.trx" || true | ||
|
|
||
| - name: Test (.NET 10) | ||
| run: dotnet test --no-restore --no-build --configuration $config --framework net10.0 --logger "trx;LogFileName=test-results-net10.trx" || true |
|
@JakubLinhart Sorry to tag you again for a review, I managed to fix the issue and the tests are picked up and executed separately for net10 and net8 
|
2 participants
Extended the Build-And-Test pipeline to also execute net10 for compatibility purposes.