hid-nintendo: restore MiSTer LED names - #97
Closed
mcfbytes wants to merge 1 commit into
Closed
Conversation
Mainline names the LEDs "<dev>:green:player-1".."-4" and "<dev>:blue:player-5"; 5.15 used "<dev>:player1".."player4" and "<dev>:home", which Main_MiSTer opens by path. With the mainline names the player and home LEDs are never set. Restore the 5.15 names.
Contributor
Author
|
Userspace alternative: MiSTer-devel/Main_MiSTer#1308 falls back to the mainline LED names in Main_MiSTer instead. Only one of the two is needed. |
Member
|
we will use mainline version to be compatible with further updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainline names the LEDs ":green:player-1".."-4" and
":blue:player-5"; 5.15 used ":player1".."player4" and
":home", which Main_MiSTer opens by path. With the mainline names
the player and home LEDs are never set. Restore the 5.15 names.