Skip to content

fix: avoid recursive proc network fallback - #61

Closed
0xdfi wants to merge 1 commit into
MiaAI-Lab:mainfrom
0xdfi:fix/proc-net-fallback
Closed

fix: avoid recursive proc network fallback#61
0xdfi wants to merge 1 commit into
MiaAI-Lab:mainfrom
0xdfi:fix/proc-net-fallback

Conversation

@0xdfi

@0xdfi 0xdfi commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Container deployments without mounted host network namespaces no longer recurse until Maximum call stack size exceeded. The fallback now reads the container's /proc/net file directly, matching the method's documented final fallback.

Validation

  • node --test server/collectors/__tests__/SystemCollector.hostNet.test.js - passed
  • The fix also passed the complete 248-test production-image suite used for the v1.8 deployment candidate.
  • Code review completed with no remaining actionable findings.

Post-Deploy Monitoring & Validation

  • Search logs for Maximum call stack size exceeded and network collector errors for 15 minutes.
  • Healthy signal: network metrics continue when neither host namespace path is mounted.
  • Failure signal: recursion, process instability, or a new network read error. Roll back this one-line fallback if observed.
  • Validation window and owner: first 15 minutes after deployment; sparkDash maintainer/operator.

Compound Engineering

@vincenzopalazzo

Copy link
Copy Markdown
Collaborator

ACK — host /proc/net recursion

Production Readiness: GO

Real bug, one-line fix, good regression test. Mutual recursion on the no-HOST_PROC path is an instant Maximum call stack size exceeded. Merge.

— Vincent

@vincenzopalazzo

Copy link
Copy Markdown
Collaborator

Already landed via #78 (Batch A ACK merge onto main). Closing this one as superseded — thanks for the contribution!

— Vincent

@vincenzopalazzo

Copy link
Copy Markdown
Collaborator

Correction: #78 is ready but not yet merged (needs MiaAI-Lab write access). Once #78 is rebase-merged, please close this PR as superseded. Thanks again!

— Vincent

@vincenzopalazzo

Copy link
Copy Markdown
Collaborator

Already merged via #78. Thanks for the contribution!

— Vincent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants