Dev/Release project support for Gradle#282
Dev/Release project support for Gradle#282mattbsox wants to merge 5 commits intoMicroShed:masterfrom
Conversation
mattbsox
force-pushed
the
boostAppConfiguration
branch
from
fcb4d4c to
c9c57ea
Compare
| warName = project.war.baseName + "-" + project.war.version | ||
| } | ||
| } else { | ||
| warName = getWarNameFromBoostApps() |
There was a problem hiding this comment.
Should we be able to install multiple wars if we find them? Also install war both from the project and dependencies?
There was a problem hiding this comment.
Changed this to use a list of war names.
| return dependencies | ||
| } | ||
|
|
||
| public static Map<String, String> getAllDependenciesFromConfiguration(Configuration configuration, BoostLogger logger) { |
There was a problem hiding this comment.
I think this method should be private since it is only called from getAllDependencies.
| compile "io.openliberty.boosters:jaxrs" | ||
| compile "io.openliberty.boosters:jdbc" | ||
| compile("org.apache.httpcomponents:httpclient:4.5.6") | ||
| compile("org.apache.httpcomponents:httpcore:4.4.10") |
| @@ -0,0 +1 @@ | |||
| /META-INF/ | |||
| logger.debug("Found dependency while processing project: " + id.group.toString() + ":" | ||
| + id.name.toString() + ":" + id.version.toString()) | ||
|
|
||
| dependencies.put(id.group.toString() + ":" + id.name.toString(), id.version.toString()) |
There was a problem hiding this comment.
I think we will only want to add the "booster" dependencies of the boostApp. Any non-booster dependency of the build project (like a db2 or mysql driver) should't be pulled in since it will conflict with what the dev project might be using. This is just my opinion and what I added into the maven build/release support, but I think additional runtime dependencies like that should be determined by the release project.
There was a problem hiding this comment.
Updated this to only return the boosters.
mattbsox
force-pushed
the
boostAppConfiguration
branch
2 times, most recently
from
6c4c023 to
ffac928
Compare
mattbsox
force-pushed
the
boostAppConfiguration
branch
from
ffac928 to
253a794
Compare
3 participants
Added the
boostAppconfiguration which can be used to specify files or Maven artifacts to be installed.Will pull in transitive dependencies from Maven artifacts.
Currently only supports wars.