Open
Conversation
Contributor
nicostuhlfauth
left a comment
nicostuhlfauth
left a comment
There was a problem hiding this comment.
Hey @FrenchFry36 👋,
Thanks for submitting your PR! This looks quite good, I just left you some small comments.
Some general tips:
- Focus on consistency: For example, in your
TaskItem.module.cssyou define some styles with class names ending inStyle, others not. I think you can safely remove it, as we always have styles here. - Please use descriptive commit messages, so it's clear what you did in the commit.
We can discuss these points in the next class!
Keep rocking 🚀
saidumarakbarov
force-pushed
the
main
branch
from
5568a9e to
e5bc0db
Compare
Form created | task-trecker | feature-branch --> main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task list part of the project has been created