Fixed Shader program error in some very specific context#34
Open
skymen wants to merge 3 commits intoMikalDev:mainfrom
Open
Fixed Shader program error in some very specific context#34skymen wants to merge 3 commits intoMikalDev:mainfrom
skymen wants to merge 3 commits intoMikalDev:mainfrom
Conversation
Owner
|
Looks good. My one thought for discussion is the perf cost of switching shaders. Need to do some perf tests with and without this change. |
Author
|
If the perf cost of switching shaders is too much, we can always disable/enable the uniforms that are not being used |
…in.js; add dev script for local development
Author
|
Yo @MikalDev did you ever find time to look into this? If not I can just fork your addon and maintain my own version for a while |
Owner
|
oooops forgot about this let me take a peek today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a bug in my level editor project and in Under The Red Sky and I finally figured out what's wrong.
All of the following needs to be true:
I finally found that the issue was the monkeypatch inside of the 3D object addon, and I replaced the code for it with this one.
I have not extensively tested it at all but this seems to be working properly.
Here is the project file for the repro to test:
test buffer overdraw simple (1).zip