feat(events): add internal event bus with typed events, listeners, an…#45
Open
dominiccreates wants to merge 4 commits into
Open
feat(events): add internal event bus with typed events, listeners, an…#45dominiccreates wants to merge 4 commits into
dominiccreates wants to merge 4 commits into
Conversation
…, and validation tests
… replace direct env access with ConfigService
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr closes #43 Implemented a lightweight internal event bus using NestJS EventEmitter2 to decouple module communication.
src/events/:events.enum.ts– enum of event names.event-payloads.ts– typed payload interfaces.event.service.ts– thin wrapper for emitting events.EventEmitterModule(global) intoAppModule.package.jsonwith@nestjs/event-emitterdependency.events.service.spec.ts) validating emission and listener handling for each event type.Benefits
Testing
Run
npm test– all new tests pass, confirming proper event flow.