Repository navigation
Persist the preferred diff renderer across reviews - #33
Merged
Merged
Conversation
rcosteira79
marked this pull request as ready for review
November 2, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting Monaco was remembered only in browser localStorage, so a review opened on another localhost port returned to Shiki. Save the renderer in the shared reviewer settings and restore it before rendering the diff or Briefing, including when resuming an older review. Keep Shiki as the default until a renderer is chosen.
Migrate an existing browser choice when no saved setting exists, let saved settings override stale browser storage, and report save failures. Preference acknowledgements preserve the current diff and drafts.
Validation: typecheck, JavaScript syntax checks, and 189 tests passed. Focused Chromium checks passed for a second review on a different port, Briefing renderer inheritance, legacy migration, stale/unavailable browser storage, startup retry, switching back to Shiki, and the existing Monaco foundation regression. The new browser regression runs in CI.