game architecture detection added to avoid KeyError: 'unknown' speedh…#35
Open
bomburr wants to merge 1 commit intoMineDojo:mainfrom
Open
game architecture detection added to avoid KeyError: 'unknown' speedh…#35bomburr wants to merge 1 commit intoMineDojo:mainfrom
bomburr wants to merge 1 commit intoMineDojo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a reliable architecture detection, speedhack client no longer dies on KeyError: 'unknown' when process queries fail.
game_env.py now tries PROCESS_QUERY_LIMITED_INFORMATION and then the PE header to detect x86 vs x64 when OpenProcess fails.
game_env.py adds an optional game_arch parameter to GamepadEnv and throws a clear error if the architecture is still unknown instead of letting xspeedhack crash.