fix: correctly set weights when w is initialized#322
Merged
stephantul merged 2 commits intomainfrom Apr 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing a trainable model with weights, we correctly set the weights in the initializer. However, when calling
_initialize, we would callconstruct_weights, which would ignore the original weights. Because_initializewas always called before fitting (it is called on every fit call), this made us effectively ignore weights.The fix is straightforward: we save the weights as
_weightsand initializewto_weightsif it is notNone. One interesting thing is that we have to project_weightsto the inverse of the sigmoid before doing so.