feat: max length behavior - #363
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
stephantul
commented
Sep 11, 2026
|
|
||
| def test_initialize_normalize(mock_vectors: np.ndarray, mock_tokenizer: Tokenizer) -> None: | ||
| """Tests whether the normalization initialization is correct.""" | ||
| model = StaticModel(mock_vectors, mock_tokenizer, {}, normalize=None) |
Contributor
Author
There was a problem hiding this comment.
stale thing, normalize was never allowed to be None
Pringled
approved these changes
Sep 11, 2026
| force_download=force_download, | ||
| ) | ||
|
|
||
| def _set_max_length_in_tokenizer(self, max_length: int | None) -> None: |
Member
There was a problem hiding this comment.
Do we also need to check for padding as well, or just truncation?
| def encode_as_sequence( | ||
| self, | ||
| sentences: str, | ||
| max_length: int | None = None, |
Member
There was a problem hiding this comment.
Part of a major release right? Otherwise we should probably deprecate this first with a warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the max length behavior so that truncations built into tokenizers are respected and overridden.