GEOPY-2813: Triangulation crash on input surface#393
Open
domfournier wants to merge 2 commits intorelease/GA_4.8from
Open
GEOPY-2813: Triangulation crash on input surface#393domfournier wants to merge 2 commits intorelease/GA_4.8from
domfournier wants to merge 2 commits intorelease/GA_4.8from
Conversation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the 1D EM driver to pass surface triangulation into the topography draping helper, aligning Base1D behavior with other parts of the codebase that already provide triangulations for Surface-based topography.
Changes:
- Import
Surfaceand conditionally passtopography_object.cellsas thetriangulationargument totopo_drape_elevationwhen the topography object is aSurface.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MatthieuCMira
approved these changes
Apr 29, 2026
| # Move this file out of the test directory and run. | ||
|
|
||
| target_run = {"data_norm": 380.3510229653626, "phi_d": 33100, "phi_m": 209} | ||
| target_run = {"data_norm": 381.0495293422212, "phi_d": 33400, "phi_m": 198} |
Contributor
There was a problem hiding this comment.
ahahah, I guess that's good.
But could you just explain why those small differences?
The original function did not changed right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2813 - Triangulation crash on input surface