Update#102
Open
amina69 wants to merge 1 commit into
Open
Conversation
Miracle656
requested changes
Jun 24, 2026
Miracle656
left a comment
Miracle656
left a comment
Owner
There was a problem hiding this comment.
This PR can't close #77. #77 is "API contract tests with Dredd", which needs a Dredd configuration and a contract-test suite wired into CI — but the only change here is to README.md, and it actually breaks the setup instruction: cp .env.example .env becomes cp .env.example.env (the space is removed, so it copies to a single nonsensically-named file). CI is also failing (typecheck + integration).
To address #77, this needs the actual Dredd setup (e.g. a dredd.yml pointing at the OpenAPI spec + a CI job running dredd), not a README edit. Please either replace this with the real implementation or close it. Also revert the .env command change — the original cp .env.example .env was correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #77
Dredd run is green
Drift flagged on PR