Skip to content

feat(web): expose support conversation context - #6727

Merged
crossle merged 1 commit into
masterfrom
feat/mixin-context-conversation-id
Oct 8, 2026
Merged

crossle merged 1 commit into
masterfrom
feat/mixin-context-conversation-id

Conversation

@SeniorZhai

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T07:45:53.962521Z d240943 PR opened
🔒 Security Review ✅ Completed 2026-10-08T07:48:26.234704Z d240943 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2409431cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}
webViewClient = BottomSheetWebViewClient()
if (isCustomerServiceUrl(this@WebBottomSheetDialogFragment.url)) {
addJavascriptInterface(SupportWebAppInterface(context), "MixinContext")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restrict the context bridge to the support origin

When the support page embeds an iframe or follows a normal HTTP(S) link, this JavaScript interface remains exposed because BottomSheetWebViewClient allows every HTTP(S) URL to load in the same WebView and the bridge is removed only during destruction. Such third-party content can therefore call MixinContext.getContext() and obtain the user's stable, account-derived support conversation identifier. Restrict HTTP(S) navigation to the customer-service origin or remove/use an origin-scoped bridge before loading any other origin.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok

@crossle
crossle merged commit e906186 into master Oct 8, 2026
1 check passed
@crossle
crossle deleted the feat/mixin-context-conversation-id branch October 8, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants