Repository navigation
Improves/pending deposit - #140
Open
hundredark wants to merge 12 commits into
Open
hundredark wants to merge 12 commits into
hundredark wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Advancing checkpoints through unfinalized blocks without reorg recovery can permanently miss replacement-block deposits.
1 open issue
What changed in this PR
This PR enables earlier pending-deposit discovery by scanning through the latest block rather than waiting for finalization.
Changes:
- Removes finalization-delay gates from both block scanners.
- Stops scanning when checkpoints reach the current chain height.
| File | Description |
|---|---|
| observer/ethereum.go | Enables tip scanning for Ethereum and Polygon deposits. |
| observer/bitcoin.go | Enables tip scanning for Bitcoin and Litecoin deposits. |
Review effort: Balanced
| for range batch { | ||
| ckpt := checkpoint + 1 | ||
| if ckpt+delay > int64(height)+1 { | ||
| if ckpt > height { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.