Skip to content

docs: clarify feed and agency language codes use BCP 47 #1987 - #2193

Merged
jcpitre merged 3 commits into
MobilityData:masterfrom
AzazelSensei:docs/bcp47-feed-lang-1987
Oct 23, 2026
Merged

jcpitre merged 3 commits into
MobilityData:masterfrom
AzazelSensei:docs/bcp47-feed-lang-1987

Conversation

@AzazelSensei

Copy link
Copy Markdown
Contributor

Summary:

The mismatch notice help text said mul comes from ISO 639-2. GTFS language fields are BCP 47, so I updated that wording on the notice and the validator class.

Fixes #1987

Expected behavior:

Help text for feed_info_lang_and_agency_lang_mismatch now says language codes follow BCP 47.

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

GTFS language fields follow IETF BCP 47. The mismatch notice help
text still called mul an ISO 639-2 code, which disagrees with the
spec.
@CLAassistant

CLAassistant commented Sep 4, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@skalexch

skalexch commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@emmambd I raised a related issue here.

@jcpitre
jcpitre self-requested a review October 19, 2026 14:45

@jcpitre jcpitre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jcpitre
jcpitre merged commit 15382cb into MobilityData:master Oct 23, 2026
103 checks passed
@welcome

welcome Bot commented Oct 23, 2026

Copy link
Copy Markdown

🥳 Congrats on getting your first pull request merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify whether language codes should be BCP 47 or ISO 639-2

5 participants